Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate/best-practices/backporting-commits.md #159

Merged
merged 2 commits into from
Aug 10, 2023
Merged

translate/best-practices/backporting-commits.md #159

merged 2 commits into from
Aug 10, 2023

Conversation

t-hamano
Copy link
Member

@t-hamano t-hamano commented Aug 8, 2023 •
edited
Loading

@t-hamano t-hamano mentioned this pull request Aug 8, 2023
Closed
@t-hamano t-hamano self-assigned this Aug 8, 2023
@t-hamano t-hamano marked this pull request as ready for review August 9, 2023 02:01
@atachibana atachibana self-requested a review August 10, 2023 09:39
atachibana
atachibana approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@atachibana atachibana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-hamano
コメントしました。その他は OK です !

core/best-practices/backporting-commits.md Outdated Show resolved Hide resolved
@t-hamano
Copy link
Member Author

@atachibana
レビューありがとうございます！ご指摘の点を修正しましたので、マージしたいと思います。

@t-hamano t-hamano merged commit e8196b5 into main Aug 10, 2023
@t-hamano t-hamano deleted the translate/best-practices/backporting-commits branch August 10, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atachibana atachibana atachibana approved these changes

Assignees

@t-hamano t-hamano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

翻訳: /best-practices/backporting-commits.md
2 participants
@t-hamano @atachibana