Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate/tutorials/faq-for-new-contributors.md #189

Merged
merged 2 commits into from
Sep 5, 2023
Merged

translate/tutorials/faq-for-new-contributors.md #189

merged 2 commits into from
Sep 5, 2023

Conversation

t-hamano
Copy link
Member

@t-hamano t-hamano commented Sep 2, 2023 •
edited
Loading

@t-hamano t-hamano force-pushed the translate/tutorials/faq-for-new-contributors.md branch from 74c2a7c to 5e163ad Compare September 2, 2023 14:38
@t-hamano t-hamano self-assigned this Sep 2, 2023
@t-hamano t-hamano mentioned this pull request Sep 2, 2023
Closed
@t-hamano t-hamano force-pushed the translate/tutorials/faq-for-new-contributors.md branch from 5e163ad to 452b90b Compare September 3, 2023 05:40
@t-hamano t-hamano marked this pull request as ready for review September 3, 2023 05:45
@atachibana atachibana self-requested a review September 4, 2023 09:33
atachibana
atachibana approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@atachibana atachibana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-hamano
いくつかコメントしました。
こういった文章はありがたいですね。

core/tutorials/faq-for-new-contributors.md Outdated Show resolved Hide resolved
core/tutorials/faq-for-new-contributors.md Outdated Show resolved Hide resolved
core/tutorials/faq-for-new-contributors.md Outdated Show resolved Hide resolved
core/tutorials/faq-for-new-contributors.md Outdated Show resolved Hide resolved
core/tutorials/faq-for-new-contributors.md Outdated Show resolved Hide resolved
@t-hamano
Copy link
Member Author

t-hamano commented Sep 5, 2023

@atachibana
レビューありがとうございます！各種ご提案通り修正しましたので、マージしたいと思います。

@t-hamano t-hamano merged commit 73d76bc into main Sep 5, 2023
@t-hamano t-hamano deleted the translate/tutorials/faq-for-new-contributors.md branch September 5, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atachibana atachibana atachibana approved these changes

Assignees

@t-hamano t-hamano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

翻訳: /tutorials/faq-for-new-contributors.md
2 participants
@t-hamano @atachibana