Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate testing/automated-testing/qunit #43

Merged
merged 8 commits into from
Nov 27, 2022

Conversation

miminari
Copy link
Member

@miminari miminari commented Jul 23, 2022

ちょっと最後が不安なので、一応、実際にテスト走らせて検証してみます。

closes #42

@miminari miminari self-assigned this Jul 23, 2022
@t-hamano
Copy link
Member

ありがとうございます!
GitHub Actions通さなくても、

  • ローカルリポジトリで npm ci
  • npm run textlint path/to/file.md

でチェック出来ます~

@miminari
Copy link
Member Author

miminari commented Jul 23, 2022

@t-hamano ありがとうございますー!すみません、textlint のことじゃなくて、QUnitのことでしたw

@miminari miminari changed the title WIP: translate testing/automated-testing/qunit Translate testing/automated-testing/qunit Jul 23, 2022
@miminari
Copy link
Member Author

@t-hamano テスト出来たので、ちょっと表現変えました。良かったらレビューお願いしますー

Copy link
Member

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miminari
ご対応ありがとうございます!
主に、ローカルでtextlintを実行して引っかかった点をコメントしました。
翻訳ルールに引っかかった点については、こちらでコミットして解決済としておきますね。

※本来は、「File changed」でこのファイルに対してGihub Actionが指摘してくれる想定でしたが、何か設定が間違ってるのかもしれません。。

core/testing/automated-testing/qunit.md Outdated Show resolved Hide resolved
core/testing/automated-testing/qunit.md Outdated Show resolved Hide resolved
core/testing/automated-testing/qunit.md Outdated Show resolved Hide resolved
core/testing/automated-testing/qunit.md Outdated Show resolved Hide resolved
core/testing/automated-testing/qunit.md Outdated Show resolved Hide resolved
core/testing/automated-testing/qunit.md Outdated Show resolved Hide resolved
@t-hamano
Copy link
Member

@miminari
こちらのPRですが、サジェストした内容で更新したものでマージさせていただきますね~

@t-hamano t-hamano merged commit d831bcc into main Nov 27, 2022
@miminari miminari deleted the translate/testing-automated-testing-qunit branch November 27, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

翻訳: automated-testing/qunit
2 participants