Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable GPU builds for windows after openxla migration and triton integration #15907

Closed
8 of 9 tasks
cloudhan opened this issue May 8, 2023 · 9 comments
Closed
8 of 9 tasks
Labels
bug Something isn't working NVIDIA GPU Issues specific to NVIDIA GPUs Windows Issues related to JAX on Microsoft Windows

Comments

@cloudhan
Copy link
Contributor

cloudhan commented May 8, 2023

Description

Build on windows is not possible since 0.4 release along with the introduction of openxla and triton. This is a meta thread to track the work needs to enable the building again.

This fixes #13646 #14165 #14369 #15876 #14950 #14939

What jax/jaxlib version are you using?

jaxlib 0.4.9 rc

Which accelerator(s) are you using?

No response

Additional system info

Native Windows 11

NVIDIA GPU info

not apply

@cloudhan cloudhan added the bug Something isn't working label May 8, 2023
@cloudhan
Copy link
Contributor Author

cloudhan commented May 8, 2023

@hawkinsp do you mind coordinating this?

@cloudhan
Copy link
Contributor Author

cloudhan commented May 15, 2023

cl.exe version 19.35.32217.1 ICE, 19.34 and older are not affected.
https://developercommunity.visualstudio.com/t/ICE-for-invoking-template-with-same-id-n/10362085

Introduced by legit change: openxla/xla@0636d61

@adam-hartshorne
Copy link

Looks like dlfcn-win32 dependency is fixed,

triton-lang/triton@323843c

@cloudhan
Copy link
Contributor Author

cloudhan commented Jun 5, 2023

@hawkinsp @chsigg only one in openxla/trition is needed. All other issues is fixed at the moment.

bazel 5.1.1 is needed, otherwise, nvcc fatal : Stray '"' due to -DBAZEL_CURRENT_REPOSITORY =\"xla\"

@jlperla
Copy link

jlperla commented Jun 7, 2023

Hi all. Excited to see the movement here. Is there any chance for a cpu-only windows JAX installable through standard pip/conda for the fall? I would love to teach with it for a course at that time (yes, I know that I can tell people to use the colab, WSL, and an unofficial conda build, but those aren't the same thing as windows support with a replicable pip requirements file/etc. I can give to low-tech users).

@hawkinsp
Copy link
Collaborator

@jlperla Yes, I think we'll be able to do that. I'm hoping we can ship Windows CPU (only) wheels in our next release.

@hawkinsp hawkinsp added the Windows Issues related to JAX on Microsoft Windows label Jun 20, 2023
@hawkinsp
Copy link
Collaborator

hawkinsp commented Sep 8, 2023

With XLA head,

I make no promises to keep testing it, but I figured I'd get it building again to see if that helps folks from the community who want to work with it.

@hawkinsp hawkinsp added the NVIDIA GPU Issues specific to NVIDIA GPUs label Sep 8, 2023
@hawkinsp hawkinsp changed the title Re-enable building for windows after openxla migration and triton integration Re-enable GPU builds for windows after openxla migration and triton integration Sep 8, 2023
@hawkinsp
Copy link
Collaborator

hawkinsp commented Sep 8, 2023

And with openxla/xla@972cd21 all the necessary changes have landed! jaxlib should build on Windows with CUDA enabled using XLA head.

@hawkinsp hawkinsp closed this as completed Sep 8, 2023
@metab0t
Copy link

metab0t commented Nov 2, 2023

It seems that xla has removed support for native GPU on Windows:
openxla/xla#6127
openxla/xla#6104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NVIDIA GPU Issues specific to NVIDIA GPUs Windows Issues related to JAX on Microsoft Windows
Projects
None yet
Development

No branches or pull requests

5 participants