[XLA:runtime] Fix compilation problem under MSVC. #5499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_563567428
branch
3 times, most recently
from
18feb64
to
38f1da5
Compare
Closed
9 tasks
~Argument() names the destructor of the superclass, and MSVC rightly complains about it in the event that (*self)[i] does not return an Argument, which it does in some cases. PiperOrigin-RevId: 563615070
copybara-service
bot
force-pushed
the
test_563567428
branch
from
38f1da5
to
cfac4c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:runtime] Fix compilation problem under MSVC.
~Argument() names the destructor of the superclass, and MSVC rightly complains about it in the event that (*self)[i] does not return an Argument, which it does in some cases.