Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XLA:GPU] Fix compilation failures under MSVC. #5501

Closed
wants to merge 0 commits into from
Closed

[XLA:GPU] Fix compilation failures under MSVC. #5501

wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

[XLA:GPU] Fix compilation failures under MSVC.

Two problems:

  • 1L is not int64 sized on Windows, leading to a template argument deduction problem.
  • MSVC limits string literals to 16K characters. However, you can use string literal concatenation to concatenate shorter literals into a long literal. Do that instead.

@hawkinsp hawkinsp mentioned this pull request Sep 8, 2023
Closed
9 tasks
cloudhan
cloudhan reviewed Sep 8, 2023
View reviewed changes
xla/service/gpu/buffer_comparator.cc Outdated
@@ -522,7 +522,8 @@ static const char* buffer_compare_ptx = R"(
$L__BB1_9:
ret;

}
})"
R"(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to add some comment in between in case someone try to merge it back...

@copybara-service copybara-service bot closed this Sep 8, 2023
@copybara-service copybara-service bot deleted the test_563575133 branch September 8, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudhan cloudhan cloudhan left review comments

Assignees

@hawkinsp hawkinsp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudhan @hawkinsp