Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EOL versions #345

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Conversation

calumy
Copy link
Contributor

@calumy calumy commented May 6, 2024

This PR removes the following end-of-life versions of Python and Django:

  • Python 3.6 - EOL: 23rd December 2021
  • Python 3.7 - EOL: 27th June 2023
  • Django 3.2 - EOL: April 2024

In addition to removing the EOL versions, the Django upgrade pre-commit hook has also been added, and fixes are included in this PR. These changes relate to:

Copy link
Collaborator

@johnraz johnraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we could merge this after the next release, like that we can issue a warning that this will be the last release to support all those older versions.

@calumy calumy marked this pull request as draft May 7, 2024 09:31
@calumy
Copy link
Contributor Author

calumy commented May 7, 2024

Drafting until #342 is merged and a new version released.

@giovannicimolin
Copy link
Contributor

@calumy This is awesome, thanks for the contribution here!

I think we can get this in shortly after our first Jazzband release.

@calumy calumy force-pushed the remove-eol-versions branch from 6a51aef to 4801921 Compare July 19, 2024 12:01
@calumy calumy marked this pull request as ready for review July 19, 2024 12:02
@calumy calumy requested a review from johnraz July 19, 2024 12:03
Copy link
Collaborator

@johnraz johnraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giovannicimolin giovannicimolin merged commit b13d550 into jazzband:develop Jul 22, 2024
6 checks passed
@giovannicimolin
Copy link
Contributor

@calumy Thanks for your contribution! :)

I'll update the changelogs and documentation of the before the next release and be sure to add a note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants