-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove EOL versions #345
Remove EOL versions #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we could merge this after the next release, like that we can issue a warning that this will be the last release to support all those older versions.
Drafting until #342 is merged and a new version released. |
@calumy This is awesome, thanks for the contribution here! I think we can get this in shortly after our first Jazzband release. |
6a51aef
to
4801921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@calumy Thanks for your contribution! :) I'll update the changelogs and documentation of the before the next release and be sure to add a note. |
This PR removes the following end-of-life versions of Python and Django:
In addition to removing the EOL versions, the Django upgrade pre-commit hook has also been added, and fixes are included in this PR. These changes relate to:
USE_L10N
, which was deprecated in Django 4.0: https://github.com/adamchainz/django-upgrade?tab=readme-ov-file#use_l10nre_path
, which has been rewritten using thepath()
syntax added in Django 2.0: https://github.com/adamchainz/django-upgrade?tab=readme-ov-file#urls