Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Norwegian bokmål translations + a little translation cleanup #1210

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

ddabble
Copy link
Member

@ddabble ddabble commented Jul 11, 2023

Description

Add Norwegian bokmål translations (cdd26c1).

Also removed an extra space in a translation (571b54c), and did a small cleanup of a couple other translation files (72bfaf7).

Related Issue

Motivation and Context

How Has This Been Tested?

Only through GitHub Actions.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@ddabble ddabble requested a review from valberg July 11, 2023 14:24
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #1210 (cdd26c1) into master (afd02c3) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
- Coverage   97.30%   97.22%   -0.08%     
==========================================
  Files          23       23              
  Lines        1260     1260              
  Branches      204      204              
==========================================
- Hits         1226     1225       -1     
  Misses         16       16              
- Partials       18       19       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@valberg valberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valberg valberg merged commit dcd1e58 into jazzband:master Jul 13, 2023
@ddabble ddabble deleted the feature/norwegian-translations branch July 14, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants