Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polygon generation #147

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Conversation

joker234
Copy link
Contributor

The polygon generation did not respect the given bounding box. The PR includes unittests for that issue and a small fix.

@joker234 joker234 force-pushed the fix-polygon-generation branch 3 times, most recently from f298bf0 to 53ac25d Compare July 28, 2020 23:02
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind checking the pypy failure?

@joker234 joker234 force-pushed the fix-polygon-generation branch 2 times, most recently from 844d838 to 0725368 Compare July 28, 2020 23:42
@joker234
Copy link
Contributor Author

would you mind checking the pypy failure?

Now, the tests should work properly. An epsilon was missing for the float comparison.

@joker234 joker234 requested a review from auvipy July 28, 2020 23:46
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joker234 joker234 force-pushed the fix-polygon-generation branch from 0725368 to ee03cec Compare July 29, 2020 11:14
@joker234
Copy link
Contributor Author

only rebased to master, no other changes here

@auvipy auvipy merged commit 2d25aeb into jazzband:master Jul 29, 2020
@joker234 joker234 deleted the fix-polygon-generation branch July 29, 2020 13:19
@rayrrr rayrrr mentioned this pull request Jan 26, 2023
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 2, 2023
3.0.1 (2023-02-15)
------------------

- Add Support for Python 3.11.x minor revisions

  - jazzband/geojson#198


3.0.0 (2023-01-26)
------------------

- Support for Python versions 3.7-3.11 (Python 2 no longer supported)

- Primary development branch renamed from `master` to `main`

- Handle all real numbers as coordinates

  - jazzband/geojson#188

- Default precision improvements

  - jazzband/geojson#177

- CI improvements

  - jazzband/geojson#172
  - jazzband/geojson#155

- utf-8 support added to `geojson.dumps()`

  - jazzband/geojson#165

- Polygons now constrained to bounding box

  - jazzband/geojson#147

- Better GeometryCollection handling in `util.coords()`

  - jazzband/geojson#146

- Improved point validation

  - jazzband/geojson#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants