Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utf-8 support to geojson.dumps #165

Merged
merged 1 commit into from
Aug 8, 2021
Merged

Add utf-8 support to geojson.dumps #165

merged 1 commit into from
Aug 8, 2021

Conversation

rayrrr
Copy link
Member

@rayrrr rayrrr commented Aug 8, 2021

Resolve issue #163

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #165 (f7ce2b5) into master (f57bc48) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files          10       10           
  Lines         350      350           
  Branches       71       71           
=======================================
  Hits          332      332           
  Misses         11       11           
  Partials        7        7           
Impacted Files Coverage Δ
geojson/codec.py 95.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57bc48...f7ce2b5. Read the comment docs.

@rayrrr rayrrr requested review from hugovk and removed request for hugovk August 8, 2021 04:28
@rayrrr rayrrr merged commit 0041e1d into master Aug 8, 2021
@rayrrr rayrrr deleted the utf-8-dumps-support branch August 8, 2021 04:35
@hugovk
Copy link
Member

hugovk commented Aug 8, 2021

I guess I was added as reviewer by mistake: no problem!

If I were to review, I'd suggest also adding a test case which fails without the fix, and passes with it.

Then it helps ensure it keeps working in the future and guards against regressions.

@rayrrr rayrrr mentioned this pull request Jan 26, 2023
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 2, 2023
3.0.1 (2023-02-15)
------------------

- Add Support for Python 3.11.x minor revisions

  - jazzband/geojson#198


3.0.0 (2023-01-26)
------------------

- Support for Python versions 3.7-3.11 (Python 2 no longer supported)

- Primary development branch renamed from `master` to `main`

- Handle all real numbers as coordinates

  - jazzband/geojson#188

- Default precision improvements

  - jazzband/geojson#177

- CI improvements

  - jazzband/geojson#172
  - jazzband/geojson#155

- utf-8 support added to `geojson.dumps()`

  - jazzband/geojson#165

- Polygons now constrained to bounding box

  - jazzband/geojson#147

- Better GeometryCollection handling in `util.coords()`

  - jazzband/geojson#146

- Improved point validation

  - jazzband/geojson#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants