Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.2.0 #936

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Release 4.2.0 #936

merged 1 commit into from
Oct 11, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Oct 11, 2019 •
edited
Loading

The pip's release is on the way. Let's release pip-tools then!

See pypa/pip#6993

@atugushev atugushev added this to the 4.2.0 milestone Oct 11, 2019
@atugushev
Copy link
Member Author

atugushev commented Oct 11, 2019 •
edited
Loading

Since #911, the next changelogs should be merged via PRs (which is great!).

$ git push upstream master
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 679 bytes | 679.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/master.

> remote: error: At least 1 approving review is required by reviewers with write access.

To github.com:jazzband/pip-tools.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:jazzband/pip-tools.git'

TODO: update "Project Release Process" in CONTRIBUTING.md.

@atugushev atugushev changed the title 4.2.0 changelog Release 4.2.0 Oct 11, 2019
@atugushev atugushev added the maintenance Related to maintenance processes label Oct 11, 2019
@atugushev atugushev self-assigned this Oct 11, 2019
davidovich
davidovich approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@davidovich davidovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atugushev
Copy link
Member Author

atugushev commented Oct 11, 2019 •
edited
Loading

@davidovich thanks! I'll cancel CIs (not to waste time) and merge this then.

@atugushev atugushev merged commit 00f3442 into jazzband:master Oct 11, 2019
@atugushev atugushev deleted the release-4.2.0 branch October 11, 2019 18:28
@codingjoe
Copy link
Member

🎉

@atugushev
Copy link
Member Author

I've uploaded the release on the jazzband PyPI server, waiting for approvement by @davidovich or @vphilippon.

@atugushev
Copy link
Member Author

pip-tools v4.2.0 is released! Thanks to all contributors, especially: @georgek, @jamescooke, @AndydeCleyre, and @hramezani!

Many thanks to @codingjoe and @blueyed for helping to review PRs.

Cheers 🎉

@atugushev atugushev mentioned this pull request Nov 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidovich davidovich davidovich approved these changes

@vphilippon vphilippon Awaiting requested review from vphilippon

@blueyed blueyed Awaiting requested review from blueyed

@codingjoe codingjoe Awaiting requested review from codingjoe

Assignees

@atugushev atugushev

Labels
maintenance Related to maintenance processes
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@atugushev @codingjoe @davidovich