Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 19.3! #6993

Closed
chrahunt opened this issue Sep 8, 2019 · 34 comments
Closed

Release 19.3! #6993

chrahunt opened this issue Sep 8, 2019 · 34 comments
Assignees
Labels
auto-locked Outdated issues that have been locked by automation type: maintenance Related to Development and Maintenance Processes
Milestone

Comments

@chrahunt
Copy link
Member

chrahunt commented Sep 8, 2019

A new release!

This would enable use of #6770 and other new improvements.

Additional context

@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Sep 8, 2019
@chrahunt chrahunt added the type: maintenance Related to Development and Maintenance Processes label Sep 8, 2019
@triage-new-issues triage-new-issues bot removed the S: needs triage Issues/PRs that need to be triaged label Sep 8, 2019
@pradyunsg
Copy link
Member

Our release month would be October. But I'm always up for figuring out our release manager early. 🙃

@xavfernandez had expressed interest in being the RM this month. As usual, I'm up for doing this if no one else is willing to pick this up. :)

@atugushev
Copy link
Contributor

@pradyunsg please ping me when you start preparing a release. I'll do quickly a pip-tools release. Thanks :)

@pradyunsg
Copy link
Member

Knock knock @pypa/pip-committers -- who wants to be the RM? I'm gonna assume it's me if no one responds expressing interest by next week, Friday. :)

@pradyunsg pradyunsg pinned this issue Sep 30, 2019
@xavfernandez
Copy link
Member

@pradyunsg I'm still interested :) . If there is nothing important to wait (like #7102) I'll aim for a release during week 41.

@pradyunsg
Copy link
Member

Looking at the rollout planned above, I think so?

I mean, we'd want to support exactly (or a subset of tags of) what PyPI accepts. As long as the PR does that and there's no mismatch, I'm cool to merge it, since AFAICT, the changes are decent there.

@xavfernandez could you please flag on the manylinux2014 rollout issue that the changes needed are not reflected in the TODO list for rollout?

@pradyunsg
Copy link
Member

pradyunsg commented Oct 4, 2019

Alrightly, we have our release manager for pip 19.3: @xavfernandez. :)
(unless other @pypa/pip-committers holler)

@xavfernandez xavfernandez added this to the 19.3 milestone Oct 7, 2019
@pradyunsg
Copy link
Member

There's a thing to be removed for pip 19.3 -- pip config --venv. Filing a PR for that.

@xavfernandez
Copy link
Member

There's a thing to be removed for pip 19.3 -- pip config --venv. Filing a PR for that.

#7163 took care of that.

Is there any other pull request / issue we would like to include in 19.3 ?

@xavfernandez
Copy link
Member

xavfernandez commented Oct 11, 2019

And I'll need to be added as maintainer in PyPI.org 😛
(username: xafer)

@chrahunt
Copy link
Member Author

#7072 is good to go, IMO. @xavfernandez, I'll leave it up to you whether we merge, since it would require regenerating AUTHORS.txt (+another hour waiting for CI).

@xavfernandez
Copy link
Member

#7072 is good to go, IMO.

I'll include it then :)

I'll wait for monday morning to actually release 19.3 since I'll have very few available time tomorrow to deal with the potential aftermath of the release.

@pradyunsg
Copy link
Member

pradyunsg commented Oct 12, 2019

@xavfernandez Sure!

I'll be online on Monday and Tuesday too, for sprints, so I will be hands-on-deck all day at that time.

@xavfernandez
Copy link
Member

I still don't have the right to upload to PyPI. Who could add me to PyPI ? @pfmoore or @dstufft ?
Otherwise, I'll make the release PR and let @pradyunsg perform the upload ?

@pradyunsg
Copy link
Member

Sounds like a plan to me. I can add you on PyPI. Lemme know whatever you prefer.

@pfmoore
Copy link
Member

pfmoore commented Oct 14, 2019

I've added you on PyPI

@pradyunsg
Copy link
Member

@xavfernandez what's your PyPI username? xavfer is already added and has the same profile picture as you.

@pradyunsg
Copy link
Member

That makes sense @pfmoore!

@pradyunsg
Copy link
Member

@xavfernandez I'm at PyCon India Sprints. Lemme know when it's okay to start merging PRs filed by folks here. :)

@xavfernandez
Copy link
Member

I've added you on PyPI

Thanks @pfmoore :)

I'm at PyCon India Sprints. Lemme know when it's okay to start merging PRs filed by folks here.

Feel free to merge the small ones: I'd first like #7198 to be merged before performing the release with it (if you could review #7198 by the way ;) ).
I see you are on IRC, I'll ping you when I'll create the release PR (around 12:00 UTC).

@xavfernandez
Copy link
Member

19.3 has been released:

I'm currently waiting for get-pip.py to be updated to post on distutils-sig & discuss.python.org

@atugushev
Copy link
Contributor

Thanks for the smooth release, folks! Excellent work! 🎉 🎉 🎉

@xavfernandez
Copy link
Member

I merged my get-pip.py PR to be able to post the announcements on distutils-sig and discuss but a review is still welcome :)

I'll keep this issue open for the week in case there are unexpected fallouts.
In the meantime, feel free to merge pull requests, I'll use a maintenance branch if a 19.3.1 is needed.

@jayvdb
Copy link

jayvdb commented Oct 15, 2019

Just noting #5599 is an issue effecting a lot of projects.

Maybe that issue should be pinned?

@pfmoore
Copy link
Member

pfmoore commented Oct 15, 2019

Pinning #5599 sounds like a reasonable suggestion - but I don't know how to do that.

Edit: Never mind, I found it.

@pradyunsg
Copy link
Member

@xavfernandez FYI, I think we should probably do a bugfix release:

@xavfernandez
Copy link
Member

#7232 is on its way.

@xavfernandez
Copy link
Member

If #7232 brings no comment, I'll merge it and push the 19.3.1 tag, sdist & wheel tomorrow morning (UTC+2).

@pradyunsg
Copy link
Member

Hurrah! Thanks @xavfernandez!

@xavfernandez
Copy link
Member

19.3.1 has been released and get-pip.py updated (and fixed 🙄 )

@SASIN83
Copy link

SASIN83 commented Oct 19, 2019

i tried to upgrade pip but it says its a new version but when i check version it shows v10 pplz help

@pradyunsg
Copy link
Member

@SASIN83 Please file a new issue: https://github.com/pypa/pip/issues/new/choose

@pradyunsg
Copy link
Member

@xavfernandez hi hi, is there anything that needs to be done?

Are there bugs that were introduced that we'd want to fix in a bugfix release?

@xavfernandez
Copy link
Member

None that I'm aware.
python/cpython#16782 still needs to be merged (or the way the vendoring is done changed), but nothing actionable on pip side.

@pradyunsg
Copy link
Member

Hurray!

Thanks @xavfernandez for managing this release super smoothly. :)

Thanks to everyone else who's helped out either with direct code/docs/triage help or by participating in the discussions! :)

@pradyunsg pradyunsg unpinned this issue Oct 29, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Nov 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

No branches or pull requests

7 participants