Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release target #7198

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Add release target #7198

merged 1 commit into from
Oct 14, 2019

Conversation

xavfernandez
Copy link
Member

No description provided.

@xavfernandez xavfernandez added type: maintenance Related to Development and Maintenance Processes skip news Does not need a NEWS file entry (eg: trivial changes) labels Oct 14, 2019
@xavfernandez xavfernandez mentioned this pull request Oct 14, 2019
Closed
pradyunsg
pradyunsg reviewed Oct 14, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me if you're gonna require this for the release. :)

I'd like us to split these out into dedicated functions, and reuse the code from generate_authors and generate_news.

@xavfernandez
Copy link
Member Author

I'd like us to split these out into dedicated functions, and reuse the code from generate_authors and generate_news.

Yup I tried to call generate_news(session) but could not find a way to provide new posargs.

I'll merge it as is to release 19.3 and we'll improve it for the next releases.

@xavfernandez xavfernandez merged commit 8df9329 into pypa:master Oct 14, 2019
@xavfernandez xavfernandez deleted the add_release_target branch October 14, 2019 12:23
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Nov 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavfernandez @pradyunsg