Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appveyor.yml: Order Pythons in descending version #258

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 15, 2019

This ordering helps identify when a problem occurs only
in older versions of Python, as AppVeyor fail-fast means
failures in the early jobs prevent seeing if latter jobs
would have succeeded.

This ordering helps identify when a problem occurs only
in older versions of Python, as AppVeyor fail-fast means
failures in the early jobs prevent seeing if latter jobs
would have succeeded.
@jayvdb jayvdb force-pushed the appveyor-python-descending branch from 31ef2c8 to 59b6ba8 Compare October 15, 2019 05:07
@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 15, 2019

New release of pip looks like it might be related pypa/pip#6993

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 15, 2019

The second commit appears to be solving the current CI problems. I can split it off to a separate PR if the first commit isnt also seen as insta-mergable.

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 15, 2019

Upstream issue is pypa/pip#5599

@@ -65,7 +65,7 @@ install:
# compiled extensions and are not provided as pre-built wheel packages,
# pip will build them from source using the MSVC compiler matching the
# target Python version and architecture
- "pip install wheel"
- "python -m pip install wheel"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big 👍 here

Copy link
Collaborator

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhermes dhermes merged commit 54d481e into wntrblm:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants