Switch to Pegdown Markdown processor from MarkdownJ #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids having problems in feed and archive with dates. Allows us to define another templates for each page type.
because WE are generating our sites. 2. asciidoc set base dir to be jbake root, now it is easy to include::content/* in our asciidoc sites.
insted of February.
|
+1 for a modern MD version. |
before the latest overwrote the previous. The default.property asciidoctor.options=source-highlighter=prettify if still overwritten when custom property is defined.
where KKK is the asciidoc key.
Because we don't know the type we guess them by their content. not perfect but ok for boolean,int and string.
|
Yeah I'd definitely consider it, as I've already had users report issues with the current library. Thanks very much for your contribution and support. :-) |
ghost
assigned 
|
+1 to see Pegdown as the markdown processor as well (I've used it myself as a lib and its very nice). Been able to format tables in markdown is the feature I'm after from jbake. |
|
Bah, I wanted to put all my changes in a single commit but I've botched the process so I'll have to do some cleanup and submit another pull request. |
|
Okay, since I've made a mess of this PR, I've cleaned it up in a new one: https://github.com/jonbullock/JBake/pull/63 Sorry for the botched clean-up of this one. |
|
No problem, I'll take a look at the new PR later on this week. |
jonbullock
pushed a commit
to jonbullock/jbake
that referenced
this pull request
Feb 11, 2022
…ry-usage-without-regression Use the worker API for Gradle 5.6 and above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm wondering if you'd consider a switch to the Pegdown Markdown processor. It has support for some very useful Markdown extensions (mostly those from GitHub and PHP). MarkdownJ has plans to support extensions, but doesn't currently. I've switched to Pegdown in this pull request and created some tests for the extra features (in the process, splitting the Markdown parser tests out into their own file). Thanks for your consideration and thanks for creating jbake.