JBERET-597 skippable exception thrown in ItemWriter triggers new chun…

[chengfang]

…k within the old transaction

https://issues.redhat.com/browse/JBERET-597

[chengfang]

@liweinan this PR should be ready to merge.

This change is in an important code block, so you may want to test it with batch TCK in Java SE, and in WildFly.

You may also want to cut a release (the last release was in July 2023) of jberet-core.

[liweinan]

@chengfang Okay! I'll do the test and then merge it to do the release, and then I'll take the work in WildFly and EAP part.

[liweinan]

I checked out this branch locally and built the JBeret:

➤ git checkout skippable.exception.JBERET-597

And then I setup the local environment according to the README in jberet-tck-porting:

export BATCH_TCK_DIR=/Users/weli/works/jberet_tck/jakarta.batch.official.tck-2.1.1
export JBERET_PORTING_DIR=/Users/weli/works/jberet_tck/jberet-tck-porting
export JBOSS_HOME=/Users/weli/works/jberet_tck/wildfly/dist/target/wildfly-30.0.0.Final-SNAPSHOT

Then I checked out jberet-tck-porting and update the jberet version accordingly:

Then I built the jberet-tck-poriting and copy the poms into the jakarta.batch.official.tck-2.1.1:

/bin/cp $JBERET_PORTING_DIR/src/main/resources/runners/sigtest/pom.xml $BATCH_TCK_DIR/runners/sigtest/pom.xml
/bin/cp $JBERET_PORTING_DIR/src/main/resources/runners/se-classpath/pom.xml $BATCH_TCK_DIR/runners/se-classpath/pom.xml
/bin/cp $JBERET_PORTING_DIR/src/main/resources/runners/platform-arquillian/pom.xml $BATCH_TCK_DIR/runners/platform-arquillian/pom.xml
/bin/cp $JBERET_PORTING_DIR/src/main/resources/runners/platform-arquillian/src/test/resources/arquillian.xml $BATCH_TCK_DIR/runners/platform-arquillian/src/test/resources/arquillian.xml

Then I replace the used jberet version in the poms of platform-arquillian and se-classpath:

The I did the SE test firstly and the tests passed:

Next I prepare WildFly to do the EE tests. I updated the jberet version used in WildFly and rebuilt it:

After the WildFly is prepared, I copied the jberet-tck-porting.jar into WildFly deployment directory:

$ cp $JBERET_PORTING_DIR/target/jberet-tck-porting.jar $JBOSS_HOME/standalone/deployments/

And started the WildFly server:

Then I did the platform-arquillian tck test:

/Users/weli/works/jberet_tck/jakarta.batch.official.tck-2.1.1/runners/platform-arquillian

And the TCK tests passed:

[liweinan]

@chengfang I have finished doing the TCK testing and record the process of testing in above. Could you please help to verify I'm doing it right? If so I'll merge this PR and do the release.

[chengfang]

@liweinan looks good. thanks for verifying it.