Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBERET-561 Change visibility of scopes implementations #432

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

liweinan
Copy link
Contributor

No description provided.

@liweinan liweinan self-assigned this Dec 14, 2023
@liweinan liweinan requested a review from a team as a code owner December 14, 2023 16:24
@liweinan
Copy link
Contributor Author

patch from: #232

@liweinan
Copy link
Contributor Author

The CI passed and I need to do tck testing for this.

After all the testings are done on the main branch I'll backport it to the branch https://github.com/jberet/jsr352/tree/2.1

@luca-bassoricci
Copy link

Latest build passed using liweinan:patching_232 as source

@liweinan
Copy link
Contributor Author

The standalone TCK test passed:

image

The next step I need to run the deployment TCK tests in WildFly.

I'm currently using these projects to do the tests manually:

In the future I need to make automate the process.

@luca-bassoricci Today it's too late for me. I'll go on working on this during the weekend and after the work is done I'll do the release.

@liweinan
Copy link
Contributor Author

relative PR: quarkiverse/quarkus-jberet#123

@liweinan
Copy link
Contributor Author

I have used the newly added test-deployment to generate the provisioned WildFly server:

And followed the steps here to do the TCK testing:

And the TCK tests passed:

image

I'll merge this PR and do the release soon.

@liweinan liweinan merged commit 81fad9b into jberet:main Dec 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants