[JBTM-3879] Xa recovery scan cursor handling #2246

marcosgopen · 2024-04-22T15:44:23Z

https://issues.redhat.com/browse/JBTM-3879

Patch XA recovery scan cursor handling
Add unit test to test the XAResourceWrapper and Recovery scan status

CORE !TOMCAT !AS_TESTS !RTS !JACOCO !XTS QA_JTA !QA_JTS_OPENJDKORB !PERFORMANCE !LRA !DB_TESTS

jbosstm-bot · 2024-04-22T15:49:00Z

Started testing this pull request with QA_JTA profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/418/

jbosstm-bot · 2024-04-22T15:49:18Z

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/418/

jbosstm-bot · 2024-04-22T15:53:49Z

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/419/

jbosstm-bot · 2024-04-22T15:53:59Z

Started testing this pull request with QA_JTA profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/419/

jbosstm-bot · 2024-04-22T16:07:31Z

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/418/

jbosstm-bot · 2024-04-22T16:10:41Z

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/419/

jbosstm-bot · 2024-04-22T17:31:22Z

QA_JTA profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/418/

jbosstm-bot · 2024-04-22T17:36:04Z

QA_JTA profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/419/

jbosstm-bot · 2024-04-22T23:36:07Z

Started testing this pull request with QA_JTA profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/423/

jbosstm-bot · 2024-04-22T23:37:36Z

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/423/

jbosstm-bot · 2024-04-22T23:56:17Z

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/423/

jbosstm-bot · 2024-04-23T01:24:20Z

QA_JTA profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/423/

ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/recovery/arjunacore/XARecoveryModule.java

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleScanUnitTest.java

mmusgrov · 2024-04-29T16:04:02Z

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

@@ -400,16 +400,24 @@ public void start(Xid xid, int i) throws XAException {
            }
        });

+        int oldCount = recoverCalled;
+        callFirstPass(xarm, oldCount);


We have lost some test precision here, before we asserted the actual number of recover calls but now we are just testing that the number is incrementing on the first path and I'd expect the test would fail if you called callSecondPass twice in a row. Since the expectation on the error free path is two recover calls (TMSTARTRSCAN and TMENDRSCAN) on the first pass and no recover calls on the second pass, the following would be more maintainable:

int oldCount = recoverCalled; callFirstPass(xarm, oldCount + 2); callSecondPass(xarm, oldCount + 2); callFirstPass(xarm, oldCount + 4); callFirstPass(xarm, oldCount + 6); callSecondPass(xarm, oldCount + 6);

or better still, because the following makes it obvious what the test is doing:

int oldCount = recoverCalled; // on the error free path // we expect periodicWorkFirstPass to make two recover calls (TMSTARTRSCAN and TMENDRSCAN), // and we expect periodicWorkSecondPass to make no recover calls xarm.periodicWorkFirstPass(); assertEquals(recoverCalled, oldCount + 2); xarm.periodicWorkSecondPass(); assertEquals(recoverCalled, oldCount + 2); xarm.periodicWorkFirstPass(); assertEquals(recoverCalled, oldCount + 4); xarm.periodicWorkFirstPass(); assertEquals(recoverCalled, oldCount + 6); xarm.periodicWorkSecondPass(); assertEquals(recoverCalled, oldCount + 6);

Thanks @mmusgrov , I will do that.

mmusgrov · 2024-04-29T16:10:12Z

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

@@ -525,20 +533,17 @@ public XAResource[] getXAResources() throws Exception {
        // 1st pass: returns one xid (count is 1)
        xarm.periodicWorkFirstPass();
        // 2nd pass: throws an exception (count is 2)


These comments are no longer valid because the second pass does not call recover(). Also the following comments stating the value of count are no longer valid. And instead of incrementing recoverCount by 2 each time sometimes it will only increment by 1 or zero if exceptions are thrown. Also it might be worthwhile using recoverCount instead of count in the dummy XAResource so that the test can continue asserting that the recover calls are called the correct number of times.

I think this test is now very confusing and may be deleted. However I will try to change it.

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

marcosgopen · 2024-04-30T10:51:02Z

I tried to change the unit tests with the new commit as you suggested @mmusgrov. WDYT?
I'll then squash the commits.
I simplified the second unit test and set the recoveryCount as global in order to assert on that too, I think it might help understanding the recovery scan logic.

jbosstm-bot · 2024-04-30T10:53:47Z

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/427/

jbosstm-bot · 2024-04-30T10:54:03Z

Started testing this pull request with QA_JTA profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK17,label=jnlp-agent/427/

jbosstm-bot · 2024-04-30T10:54:04Z

Started testing this pull request with QA_JTA profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/427/

jbosstm-bot · 2024-04-30T10:54:09Z

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/427/

jbosstm-bot · 2024-04-30T11:11:50Z

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/427/

jbosstm-bot · 2024-04-30T11:24:13Z

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/427/

jbosstm-bot · 2024-04-30T12:35:11Z

QA_JTA profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK17,label=jnlp-agent/427/

jbosstm-bot · 2024-04-30T12:41:40Z

QA_JTA profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/427/

mmusgrov

The main change request is the method that tests the recovery module with exceptions ie testRecoverPassFailure.

mmusgrov · 2024-04-30T15:23:44Z

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

@@ -57,6 +57,7 @@
 public class XARecoveryModuleUnitTest
 {
    private boolean rolledback;
+    private int recoverCount = 0;


The other similar variable is declared at the end of the class, can't you declare them both in the same place? And can't you also use the same variable for the two tests initialising them in the method. Another option is to make the tests independent using a method local variable:

public void testCanRepeatFirstPass () { final int[] recoverCalled = new int [1]; ... recoverCalled[0] += 1; etc

But personally, to minimise the change set, I'd just reuse recoverCalled for the second test since we cannot run these surefire tests in parallel.

Also i would initialise the counters in the methods that use them since it makes the tests brittle.

I'm also doubting that recoverCount needs to be declared as an instance variable: the asserts for the value don't add anything since recoverCount is internal to how the test operates, the code comments about recoverCount should be sufficient.

Agreed, so I will restore the previous variable (count) and just rename it to 'recoverCount'.

mmusgrov · 2024-04-30T15:37:24Z

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

-                    count++;
-                    if (count == 1 || count == 5) {
+                    recoverCount++;
+                    if (recoverCount == 1 || recoverCount == 2) {


The logic is no longer the same as the original code and it is testing something different. The original generated an exception on the first two cycles and an array of 1 xid on the third cycle. So I think the recover logic needs to be as follows:

public Xid[] recover(int i) throws XAException { recoverCount += 1; if (recoverCount == 1 || recoverCount == 3 || recoverCount == 5) { return new Xid[]{xid}; // TMSTARTRSCAN } else if (recoverCount > 5) { return new Xid[0]; // TMSENDRSCAN when recoverCount == 6 so the recovery pass succeeds } else { throw new XAException(); // if recoverCount is 2 or 4 ie the TMSENDRSCAN call } }

Thanks @mmusgrov , PR updated

mmusgrov · 2024-04-30T15:38:08Z

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

                        return new Xid[]{xid};
-                    } else if (count > 5) {
+                    }


This is a code formatting change that doesn't flow with the formatting around it.

Thanks, updated.

mmusgrov · 2024-04-30T16:01:07Z

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

                        return new Xid[]{xid};
-                    } else if (count > 5) {
+                    }
+                    else if (recoverCount > 3) {
                        return new Xid[0];
                    } else {


This else arm is unreachable since recoverCount starts out at 1 and the final else is (recoverCount > 3), ie the code is not very maintainable.

BTW in my other comment I suggested an alternative implementation of the recover method.

Thanks, updated

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

jbosstm-bot · 2024-05-02T09:48:41Z

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/429/

jbosstm-bot · 2024-05-02T10:19:33Z

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/429/

mmusgrov

I had two minor change requests but the PR is looking good.

Can you also squash the four commits for the test changes - in an ideal world we'd want the tests to be with the functional change but I think it is useful taking Jonathan's commit as is.

mmusgrov · 2024-05-02T10:13:40Z

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

@@ -441,8 +446,7 @@ public String getProductVersion() {
                public String getJndiName() {
                    return "test";
                }
-
-                int count = 0;
+                int recoverCount = 0;


Now that you have gone back to the original use of this variable I think it should keep the original name - in the future it will make code diffs simpler to analyse.

Thanks, updated

mmusgrov · 2024-05-02T10:16:53Z

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

+                    recoverCount++;
+                    if (recoverCount == 1 || recoverCount == 3 || recoverCount == 5) {
+                        return new Xid[] { xid }; // TMSTARTRSCAN
+                    }else if (recoverCount > 5) {


The code reformat has dropped the space between } and else which makes it inconsistent with the rest of the code in this file.

Thanks, updated.

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

jbosstm-bot · 2024-05-02T11:30:52Z

QA_JTA profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK17,label=jnlp-agent/429/

jbosstm-bot · 2024-05-02T11:39:48Z

QA_JTA profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/429/

marcosgopen · 2024-05-02T13:10:49Z

@mmusgrov I have created the JBTM (feel free to add comments/update the description) for it and squash the commits as suggested.

jbosstm-bot · 2024-05-02T13:13:37Z

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/430/

jbosstm-bot · 2024-05-02T13:13:47Z

Started testing this pull request with QA_JTA profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK17,label=jnlp-agent/430/

jbosstm-bot · 2024-05-02T13:13:55Z

Started testing this pull request with QA_JTA profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/430/

jbosstm-bot · 2024-05-02T13:13:57Z

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/430/

jbosstm-bot · 2024-05-02T13:32:08Z

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/430/

jbosstm-bot · 2024-05-02T13:43:38Z

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/430/

mmusgrov · 2024-05-02T14:22:52Z

ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/recovery/XARecoveryModuleUnitTest.java

@@ -441,7 +446,6 @@ public String getProductVersion() {
                public String getJndiName() {
                    return "test";
                }
-
                int count = 0;


Thanks for changing it back to count. Quite a few comments still refer to recoverCount, will you change those to count too please.

Sure, I forgot about that. Updated, thanks

jbosstm-bot · 2024-05-02T14:53:45Z

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/431/

jbosstm-bot · 2024-05-02T14:53:51Z

Started testing this pull request with QA_JTA profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK17,label=jnlp-agent/431/

jbosstm-bot · 2024-05-02T14:53:57Z

Started testing this pull request with QA_JTA profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/431/

jbosstm-bot · 2024-05-02T14:54:03Z

Started testing this pull request with CORE profile: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/431/

jbosstm-bot · 2024-05-02T14:55:38Z

QA_JTA profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK17,label=jnlp-agent/430/

jbosstm-bot · 2024-05-02T15:00:25Z

QA_JTA profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/430/

jbosstm-bot · 2024-05-02T15:11:54Z

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK11,label=jnlp-agent/431/

jbosstm-bot · 2024-05-02T15:22:28Z

CORE profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=openJDK17,label=jnlp-agent/431/

jbosstm-bot · 2024-05-02T16:32:35Z

QA_JTA profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK17,label=jnlp-agent/431/

jbosstm-bot · 2024-05-02T16:41:13Z

QA_JTA profile tests passed - Job complete https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=openJDK11,label=jnlp-agent/431/

Patch XA recovery scan cursor handling

2e08bd2

marcosgopen marked this pull request as draft April 22, 2024 15:44

marcosgopen force-pushed the xa-recovery-scan branch from c3c3383 to 2bc0624 Compare April 22, 2024 15:49

marcosgopen marked this pull request as ready for review April 29, 2024 10:31

mmusgrov requested changes Apr 29, 2024

View reviewed changes

marcosgopen mentioned this pull request Apr 30, 2024

AG-238 add connection test agroal/agroal#103

Closed

graben mentioned this pull request May 1, 2024

Delay opening of recovery connection agroal/agroal#104

Merged

mmusgrov requested changes May 1, 2024

View reviewed changes

mmusgrov requested changes May 2, 2024

View reviewed changes

marcosgopen changed the title ~~Xa recovery scan~~ [JBTM-3879] Xa recovery scan cursor handling May 2, 2024

marcosgopen force-pushed the xa-recovery-scan branch from 0c607ef to 66c3132 Compare May 2, 2024 13:09

mmusgrov requested changes May 2, 2024

View reviewed changes

marcosgopen force-pushed the xa-recovery-scan branch from 66c3132 to 45b09d2 Compare May 2, 2024 14:50

JBTM-3879 XA recovery scan cursor handling test

d080f02

marcosgopen force-pushed the xa-recovery-scan branch from 45b09d2 to d080f02 Compare May 2, 2024 14:51

mmusgrov approved these changes May 2, 2024

View reviewed changes

marcosgopen merged commit ae47556 into jbosstm:main May 3, 2024

marcosgopen mentioned this pull request Jun 28, 2024

Update Narayana to 7.0.2.Final snowdrop/narayana-spring-boot#148

Merged

[JBTM-3879] Xa recovery scan cursor handling #2246

[JBTM-3879] Xa recovery scan cursor handling #2246

Conversation

marcosgopen commented Apr 22, 2024 • edited Loading

jbosstm-bot commented Apr 22, 2024

jbosstm-bot commented Apr 22, 2024

jbosstm-bot commented Apr 22, 2024

jbosstm-bot commented Apr 22, 2024

jbosstm-bot commented Apr 22, 2024

jbosstm-bot commented Apr 22, 2024

jbosstm-bot commented Apr 22, 2024

jbosstm-bot commented Apr 22, 2024

jbosstm-bot commented Apr 22, 2024

jbosstm-bot commented Apr 22, 2024

jbosstm-bot commented Apr 22, 2024

jbosstm-bot commented Apr 23, 2024

mmusgrov Apr 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcosgopen commented Apr 30, 2024 • edited Loading

jbosstm-bot commented Apr 30, 2024

jbosstm-bot commented Apr 30, 2024

jbosstm-bot commented Apr 30, 2024

jbosstm-bot commented Apr 30, 2024

jbosstm-bot commented Apr 30, 2024

jbosstm-bot commented Apr 30, 2024

jbosstm-bot commented Apr 30, 2024

jbosstm-bot commented Apr 30, 2024

mmusgrov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmusgrov Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

mmusgrov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

marcosgopen commented May 2, 2024 • edited Loading

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

jbosstm-bot commented May 2, 2024

marcosgopen commented Apr 22, 2024 •

edited

Loading

mmusgrov Apr 29, 2024 •

edited

Loading

marcosgopen commented Apr 30, 2024 •

edited

Loading

mmusgrov Apr 30, 2024 •

edited

Loading

marcosgopen commented May 2, 2024 •

edited

Loading