Update Narayana to 7.0.2.Final

[graben]

Dependent on #149, agroal/agroal#109

[graben]

@marcosgopen: Trying to update to Narayana 7.0.2.Final causing tests to fail. There might be an issue to address before official announce?

[marcosgopen]

Thanks @graben for letting me know. I will have a look.

[graben]

Thanks @graben for letting me know. I will have a look.

Give me a hint if I can help!

[marcosgopen]

Thanks @graben for letting me know. I will have a look.

Give me a hint if I can help!

TBF we are not encountering a failure in our regression tests, so this is very interesting. The change that affected your test is jbosstm/narayana#2246, but still we are working to find out why. I will keep you updated.

[graben]

Well, it seems that an early called recover(XAResource.TMENDRSCAN) does cause a disconnect of the internal used JDBC connection. (

narayana-spring-boot/narayana-spring-boot-core/src/main/java/dev/snowdrop/boot/narayana/core/jdbc/DataSourceXAResourceRecoveryHelper.java

Line 112 in 2d94a3e

disconnect();

)

Btw. Agroal unit test does fail, too also used here for pooling integration

FYI @barreiro

[graben]

Maybe DataSourceXAResourceRecoveryHelper needs to be refit for 7.0.2. Not really nice for a patch update of a dependency :/

[mmusgrov]

Well, it seems that an early called recover(XAResource.TMENDRSCAN) does cause a disconnect of the internal used JDBC connection. (

narayana-spring-boot/narayana-spring-boot-core/src/main/java/dev/snowdrop/boot/narayana/core/jdbc/DataSourceXAResourceRecoveryHelper.java

Line 112 in 2d94a3e

disconnect();

)
Btw. Agroal unit test does fail, too also used here for pooling integration

FYI @barreiro

Agreed Benjamin, Marco has raised a PR to revert the fix we made for the Agroal issue.

[graben]

Oh, I'm sorry for that. Maybe the patch could be reused for a major version upgrade again?

[marcosgopen]

After updating Narayana to 7.0.2.Final the PooledTransactionalIT test fails with : ''[ERROR] Errors:
[ERROR] PooledRecoveryIT>GenericRecoveryIT.testCrashBeforeCommit:122 » ConditionTimeout Condition with alias 'Wait for the recovery to happen' didn't complete within 1 minutes because assertion condition with alias Wait for the recovery to happen [Test entry should exist after transaction was committed]
Expected size: 1 but was: 0 in:
[]."

That is because of another issue Review JTS and JTA way to handle RMFAIL in xa_rollback. In fact Narayana 7.0.2.Final is not treating XAER_RMFAIL as a transient failure and would consider it a heuristic aligning to xa_rollback specification (https://publications.opengroup.org/c193)

From the test log you can read: "WARN 170836 --- [nsaction Reaper] com.arjuna.ats.arjuna : ARJUNA012117: TransactionReaper::check processing TX 0:ffffc0a82b22:a64d:66840d2a:1e in state RUN"

This is a issue that might have already been solved by Artemis team (maybe apache/activemq-artemis@269be13c5a). FYI @graben

[graben]

As already mentioned in #149, I'm waiting for an enhanced version of Agroal to workaround a H2 issue.

[graben]

@geoand : Now this one is ready ;)