Improvements #29
Open
Improvements #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added alg description to hmacSha256 signer function. Added genesys-audiohook test. Fixed signature expiration check bug - added 1 minute wiggle room for signature expiration.
…tion to transport middleware. Fixed a bug where signature-input fields were expected to not have `=` symbol - e.g., keyid could be base64 encoded, so could have `=`. Created a NewSigner() constructor so that `nowFunc` can be set to `time.Now` automatically. Fixed `@request-target` resolution - setting its value to url.RequestURI().
…the spec. Also, the error returned now is `401 Unauthorized` instead of `400 Bad Request`.
…ding 1 min instead of subtracting it from current time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=in their values now