Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #29

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Improvements #29

wants to merge 6 commits into from

Commits on Jan 22, 2024

  1. Adding @request-target.

    @c-nyuldashev
    c-nyuldashev committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    21884fb View commit details
    Browse the repository at this point in the history

  2. Fixing @request-target value.

    @c-nyuldashev
    c-nyuldashev committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    267c1ae View commit details
    Browse the repository at this point in the history

  3. Made signatureParams parameters ordered by adding paramsOrder. 

    Added alg description to hmacSha256 signer function.
Added genesys-audiohook test.
Fixed signature expiration check bug - added 1 minute wiggle room for signature expiration.
    @c-nyuldashev
    c-nyuldashev committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6fdbace View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Making Signer/Verifier interfaces public, so they can be used in addi… 

    …tion to transport middleware.

Fixed a bug where signature-input fields were expected to not have `=` symbol - e.g., keyid could be base64 encoded, so could have `=`.
Created a NewSigner() constructor so that `nowFunc` can be set to `time.Now` automatically.
Fixed `@request-target` resolution - setting its value to url.RequestURI().
    @c-nyuldashev
    c-nyuldashev committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    5f57646 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Adding logic to remove default port from Host field as required by … 

    …the spec.

Also, the error returned now is `401 Unauthorized` instead of `400 Bad Request`.
    @c-nyuldashev
    c-nyuldashev committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    bcf35d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Lessening expiry check - was mistakenly strengthening the check by ad… 

    …ding 1 min instead of subtracting it from current time.
    @c-nyuldashev
    c-nyuldashev committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    e56f275 View commit details
    Browse the repository at this point in the history