some typedefs for MSVC 2008

[chris-b1]

ref pandas-dev#22235

[jbrockmendel]

I'll trust you if you say this is necessary, but this doesn't make sense to me. I took the ctypedef signed long long int64_t from the numpy __init__.pxd, so shouldn't these be equivalent?

(Using the extern version instead of the cimport version is necessary to avoid the NPY_NO_DEPRECATED warnings)

[chris-b1]

I believe "numpy/arrayobject.h" only defines npy_int64 - it is only the cython pxd that also typedefs this to int64_t.

So then this typedef is basically a noop (?)

    ctypedef signed long long int64_t

The function failing to compile is this one from util.pxd. <stdint.h> is normally included in cython generated code, so on all platforms but MSVC 2008 it is providing the necessary int64_t typedef

cdef inline int64_t get_nat():
    return NPY_MIN_INT64

[jbrockmendel]

Thanks for clearing this up. Is there a viable fix that doesn't involve the from numpy cimport?

I'm going to merge this here so we can move the master-PR along; hopefully we can get rid of the cimport in the next round of cython-cleaning.

[jbrockmendel]

Would “from libc.stdint cimport int64_t” work cross-platform? That would make some nice simplifications feasible.

[chris-b1]

It does not - MSVC 2008 didn't ship a <stdint.h> which is why we have our shim

# Python 2.7.15 |Anaconda, Inc.| (default, May  1 2018, 18:37:09) [MSC v.1500 64 bit (AMD64)]

%%cython
from libc.stdint cimport int64_t
def add_one(int64_t a):
    return a + 1

# ~\.ipython\cython\_cython_magic_d325870c8ea59abec727c4b979472cb0.c(579) : 
fatal error C1083: Cannot open include file: 'stdint.h': No such file or directory