Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add envs for rtx go core plugin #679

Merged
merged 6 commits into from
Jul 14, 2023
Merged

Conversation

dfang
Copy link
Contributor

@dfang dfang commented Jul 14, 2023

#677

for env names: RTX_GO_REPO RTX_GO_REPOSITORY RTX_GO_DOWNLOAD_MIRROR RTX_GOLANG_DOWNLOAD_MIRROR, since there is RTX_GO_SKIP_CHECKSUM already in src/env.rs, I choose short version too.

@jdx jdx enabled auto-merge (squash) July 14, 2023 13:01
src/env.rs Outdated Show resolved Hide resolved
auto-merge was automatically disabled July 14, 2023 13:28

Head branch was pushed to by a user without write access

src/plugins/core/go.rs Outdated Show resolved Hide resolved
src/plugins/core/go.rs Outdated Show resolved Hide resolved
dfang and others added 2 commits July 14, 2023 22:36
Co-authored-by: Jeff Dickey <216188+jdxcode@users.noreply.github.com>
Co-authored-by: Jeff Dickey <216188+jdxcode@users.noreply.github.com>
@dfang dfang requested a review from jdx July 14, 2023 14:40
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -6.44 ⚠️

Comparison is base (0145de9) 86.80% compared to head (aa43df9) 80.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
- Coverage   86.80%   80.37%   -6.44%     
==========================================
  Files         129      129              
  Lines       11159    11157       -2     
==========================================
- Hits         9687     8967     -720     
- Misses       1472     2190     +718     
Impacted Files Coverage Δ
src/env.rs 84.75% <100.00%> (-3.74%) ⬇️
src/plugins/core/go.rs 78.39% <100.00%> (-10.30%) ⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdx
Copy link
Owner

jdx commented Jul 14, 2023

I've gone ahead and run cargo fmt for you to fix the lint issues in this PR but please run that yourself on your other PRs

@jdx jdx enabled auto-merge (squash) July 14, 2023 14:50
@dfang
Copy link
Contributor Author

dfang commented Jul 14, 2023

I've gone ahead and run cargo fmt for you to fix the lint issues in this PR but please run that yourself on your other PRs

ok, I will update code on local not GitHub web editor and run cargo fmt before commit.

@jdx jdx merged commit 2be8c64 into jdx:main Jul 14, 2023
jdx pushed a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants