Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add envs for rtx node core plugin #680

Merged
merged 5 commits into from
Jul 14, 2023
Merged

add envs for rtx node core plugin #680

merged 5 commits into from
Jul 14, 2023

Conversation

dfang
Copy link
Contributor

@dfang dfang commented Jul 14, 2023

@jdx jdx enabled auto-merge (squash) July 14, 2023 13:05
@jdx jdx disabled auto-merge July 14, 2023 13:29
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -4.03 ⚠️

Comparison is base (57a7340) 88.13% compared to head (96596c8) 84.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   88.13%   84.11%   -4.03%     
==========================================
  Files         129      129              
  Lines       11169    11172       +3     
==========================================
- Hits         9844     9397     -447     
- Misses       1325     1775     +450     
Impacted Files Coverage Δ
src/env.rs 85.96% <100.00%> (-2.69%) ⬇️
src/plugins/core/node.rs 86.04% <100.00%> (ø)

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dfang
Copy link
Contributor Author

dfang commented Jul 14, 2023

@jdxcode the unit test failed, I can't fix this, can you help on this

@jdx
Copy link
Owner

jdx commented Jul 14, 2023

I don't think it's related to your change. Let's see if it passes after we update the branch.

@jdx jdx enabled auto-merge (squash) July 14, 2023 15:46
@jdx jdx merged commit db5b02d into jdx:main Jul 14, 2023
jdx pushed a commit that referenced this pull request Apr 9, 2024
Co-authored-by: James Hegedus <jthegedus@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants