Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Background color is not correctly detected/used when using manim-slides convert #409

Closed
jeertmans opened this issue Apr 15, 2024 · 0 comments · Fixed by #414
Closed

[BUG] Background color is not correctly detected/used when using manim-slides convert #409

jeertmans opened this issue Apr 15, 2024 · 0 comments · Fixed by #414
Labels
bug Something isn't working lib Related to the library (a.k.a. module)
Milestone
v6

Comments

@jeertmans
Copy link
Owner

Description

The HTML conversion (and I guess others) does not seem to use the right background color, as noticed on my presentation slides.

Either the color is not correctly exported to the JSON files, or the color is not properly used. One out of my 4 existing slides did correctly use the non-default color (i.e., not BLACK).

Version

v5.1.3

Platform

Not relevant

Screenshots

No response

Additional information

No response
@jeertmans jeertmans added bug Something isn't working lib Related to the library (a.k.a. module) labels Apr 15, 2024
@jeertmans jeertmans added this to the v6 milestone Apr 15, 2024
jeertmans added a commit that referenced this issue Apr 16, 2024
@jeertmans
fix(lib): correctly retrieve background color
1e0d3ad 
Closes #409
@jeertmans jeertmans mentioned this issue Apr 16, 2024
Merged
jeertmans added a commit that referenced this issue Apr 16, 2024
@jeertmans
fix(lib): correctly retrieve background color (#414)
498e9af 
Closes #409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working lib Related to the library (a.k.a. module)
Projects
None yet
Milestone
v6
Development

Successfully merging a pull request may close this issue.

fix(lib): correctly retrieve background color jeertmans/manim-slides
1 participant
@jeertmans