Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): correctly retrieve background color #414

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix(lib): correctly retrieve background color #414

merged 1 commit into from
Apr 16, 2024

Conversation

jeertmans
Copy link
Owner

Closes #409

@jeertmans jeertmans added bug Something isn't working lib Related to the library (a.k.a. module) labels Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.58%. Comparing base (24ee23a) to head (1e0d3ad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #414   +/-   ##
=======================================
  Coverage   79.58%   79.58%           
=======================================
  Files          22       22           
  Lines        1812     1812           
=======================================
  Hits         1442     1442           
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans jeertmans merged commit 498e9af into main Apr 16, 2024
20 of 23 checks passed
@jeertmans jeertmans deleted the bg-color branch April 16, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib Related to the library (a.k.a. module)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Background color is not correctly detected/used when using manim-slides convert
1 participant