Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display 'Prediction Result' as a separate component #2897

Closed
jeff1evesque opened this issue Feb 4, 2017 · 14 comments
Closed

Display 'Prediction Result' as a separate component #2897

jeff1evesque opened this issue Feb 4, 2017 · 14 comments

Comments

@jeff1evesque
Copy link
Owner

jeff1evesque commented Feb 4, 2017

Instead of rendering the Prediction Result as a separate fieldset, at the bottom of the webpage:

prediction-result

We should display it as a separate component, on it's own dedicated webpage. Additionally, we'll need to allocate the new webpage, it's own dedicated route definition. Therefore, the /session/model-predict page will need to provide a <Link> to the new result page, upon prediction completion. To make all this work, we'll need to store the results into redux, so it can be accessible within the new prediction result page.

@jeff1evesque
Copy link
Owner Author

55b26a7: probably should have gone into it's own dedicated issue. However, we decided to simplify, and standardize all reactjs filenames, and corresponding classnames.

@jeff1evesque
Copy link
Owner Author

When we click the above Goto results button, we are correctly redirected:

empty-page

However, we need to debug whether our redux is not properly wired, or our results page logic doesn't properly decouple the results object, into presentational content. In the future, we may consider storing our results into sessionStorage, since on a browser refresh our redux store will be emptied.

@jeff1evesque
Copy link
Owner Author

We are able to discern that our presentational content is available, as indicated in the console.log output:

not-rendering

However, we have not properly decoupled the data from our corresponding redux container.

@jeff1evesque
Copy link
Owner Author

We are receiving Warning: Each child in an array or iterator should have a unique "key" prop.:

unique-key

@jeff1evesque
Copy link
Owner Author

We are receiving SCRIPT438: Object doesn't support property or method 'entries' within Internet Explorer, after clicking the Goto results button:

internet-explorer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant