Subsonic 2, general rework #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Main weird thing that I haven't quite resolved is updating playlist when an item is removed. Other things should work fine (although fetching large playlists will be. long) |
|
I might not have the time to go through every change, but as long as it's functional I'm fine with merging. I'm not seeing the issue with playlist updates when a song is removed (it's working fine for me?), but the playlist list page itself is erroring out due to missing filters for subsonic. I'll update as I go through it. |
|
Couple more issues:
|
|
With this merged, might be a good idea to update the What music servers does Feishin support FAQ part of the readme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from and supersedes #419. Resolves #306.