Fix system file browser not being invoked #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! I gave it a quick glance already and the changes look good, I'll try to review it more thoroughly in the next few days. |
Maxr1998
force-pushed
the
fix-subtitle-file-browser-invocation
branch
from
fb7ce5c to
3411b62
Compare
- Use interface instead of functional type to pass intent and callback - Register activity launcher unconditionally as recommended in method documentation - Use FileChooserParams#createIntent and FileChooserParams.parseResult helpers
It doesn't do just logging anymore.
|
I refactored it a bit to use more specific APIs to handle the |
Maxr1998
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fix adds the invocation of the system file picker for
onShowFileChooserin the WebChromeClient to enable the upload of local subtitle files.It implements the recommendation of @Maxr1998 in issue #1082
Issues
Fixes #1082