Ensure that Windows 2019 images have CURL when publishing incrementals #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow windows to also run deploy
Closed
jetersen
commented
Apr 8, 2020
| @@ -259,11 +259,17 @@ void prepareToPublishIncrementals() { | |||
| void maybePublishIncrementals() { | |||
| if (isRunningOnJenkinsInfra() && currentBuild.currentResult == 'SUCCESS') { | |||
| stage('Deploy') { | |||
| node('maven || linux') { | |||
| node('maven || linux || windows') { | |||
There was a problem hiding this comment.
Could potentially drop the label spec if all windows nodes are using 2019 base.
olblak
approved these changes
Apr 9, 2020
|
If curl.exe is not already available on windows machine, feel free to add on the packer images. Link |
|
Nah it should already be there, Microsoft put it in :) https://devblogs.microsoft.com/commandline/tar-and-curl-come-to-windows/ This includes server and even docker images for both server core and nanoserver. |
jglick
reviewed
Apr 9, 2020
| ''' | ||
| } else { | ||
| bat ''' | ||
| curl.exe -i -H 'Content-Type: application/json' -d '{"build_url":"'%BUILD_URL%'"}' "https://jenkins-community-functions.azurewebsites.net/api/incrementals-publisher?clientId=default&code=%FUNCTION_TOKEN%" || echo 'Problem calling Incrementals deployment function' |
There was a problem hiding this comment.
Does ' work in batch scripts? Did you try this command with a -v and a phony token environment variable?
There was a problem hiding this comment.
I tested locally that the current string should work
There was a problem hiding this comment.
https://ci.jenkins.io/job/Plugins/job/azure-credentials-plugin/job/master/35/execution/node/102/log/ suggests this is broken:
FailRequestError: The incrementals-publisher invocation was missing the build_url attribute
at IncrementalsPlugin.main (D:\home\site\wwwroot\incrementals-publisher\index.js:133:13)
at module.exports (D:\home\site\wwwroot\incrementals-publisher\index.js:266:29)
at WorkerChannel.invocationRequest (D:\Program Files (x86)\SiteExtensions\Functions\3.0.13139\64bit\workers\node\worker-bundle.js:17928:26)
at ClientDuplexStream.WorkerChannel.eventStream.on (D:\Program Files (x86)\SiteExtensions\Functions\3.0.13139\64bit\workers\node\worker-bundle.js:17738:30)
at ClientDuplexStream.emit (events.js:198:13)
at addChunk (_stream_readable.js:288:12)
at readableAddChunk (_stream_readable.js:269:11)
at ClientDuplexStream.Readable.push (_stream_readable.js:224:10)
at Object.onReceiveMessage (D:\Program Files (x86)\SiteExtensions\Functions\3.0.13139\64bit\workers\node\worker-bundle.js:21909:19)
at InterceptingListener.module.exports.InterceptingListener.recvMessageWithContext (D:\Program Files (x86)\SiteExtensions\Functions\3.0.13139\64bit\workers\node\worker-bundle.js:21224:19)
at D:\Program Files (x86)\SiteExtensions\Functions\3.0.13139\64bit\workers\node\worker-bundle.js:21323:14
There was a problem hiding this comment.
I suspect this was a copy paste error on my part.
Suggested change
| curl.exe -i -H 'Content-Type: application/json' -d '{"build_url":"'%BUILD_URL%'"}' "https://jenkins-community-functions.azurewebsites.net/api/incrementals-publisher?clientId=default&code=%FUNCTION_TOKEN%" || echo 'Problem calling Incrementals deployment function' | |
| curl.exe -i -H 'Content-Type: application/json' -d '{"build_url":"%BUILD_URL%"}' "https://jenkins-community-functions.azurewebsites.net/api/incrementals-publisher?clientId=default&code=%FUNCTION_TOKEN%" || echo 'Problem calling Incrementals deployment function' |
There was a problem hiding this comment.
After actually testing it against site. I noticed a few things such as encoding being URL encoded...
Suggested change
| curl.exe -i -H 'Content-Type: application/json' -d '{"build_url":"'%BUILD_URL%'"}' "https://jenkins-community-functions.azurewebsites.net/api/incrementals-publisher?clientId=default&code=%FUNCTION_TOKEN%" || echo 'Problem calling Incrementals deployment function' | |
| curl.exe -i -H "Content-Type: application/json" -d "{""build_url"":""%BUILD_URL%""}" "https://jenkins-community-functions.azurewebsites.net/api/incrementals-publisher?clientId=default&code=%FUNCTION_TOKEN%" || echo Problem calling Incrementals deployment function |
There was a problem hiding this comment.
oleg-nenashev
changed the title
oleg-nenashev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow windows to also run deploy