Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batch quoting in maybePublishIncrementals #142

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fix batch quoting in maybePublishIncrementals #142

merged 1 commit into from
Apr 23, 2020

Conversation

jetersen
Copy link
Contributor

@jetersen jetersen commented Apr 23, 2020 •
edited
Loading

Thanks for pointing me to a build @jglick 😅

fixes #140

@jetersen jetersen requested a review from a team April 23, 2020 14:50
@jetersen
Copy link
Contributor Author

jetersen commented Apr 23, 2020 •
edited
Loading

Tested curl command against webhook.site

set BUILD_URL=https://hello.com
curl.exe -i -H "Content-Type: application/json" -d "{""build_url"":""%BUILD_URL%""}" https://webhook.site/f191615b-6a98-444f-9d7d-7fbcf563ab18
HTTP/1.1 200 OK
Server: nginx/1.14.2
Content-Type: text/plain; charset=UTF-8
Transfer-Encoding: chunked
Vary: Accept-Encoding
X-Request-Id: 656da543-7000-49ac-8d8b-7601f0e8d91d
X-Token-Id: f191615b-6a98-444f-9d7d-7fbcf563ab18
Cache-Control: no-cache, private
Date: Thu, 23 Apr 2020 14:51:52 GMT
Set-Cookie: laravel_session=P4CUuIwyCWyEopv9NejUOHaS084MXfDMJIWmu3Wi; expires=Thu, 23-Apr-2020 16:51:52 GMT; Max-Age=7200; path=/; httponly

https://webhook.site/#!/f191615b-6a98-444f-9d7d-7fbcf563ab18/656da543-7000-49ac-8d8b-7601f0e8d91d/1

jglick
jglick approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olblak please merge

@timja timja mentioned this pull request Apr 23, 2020
Closed
@olblak olblak merged commit e245495 into jenkins-infra:master Apr 23, 2020
@oleg-nenashev
Copy link
Contributor

Belated +1

@jetersen jetersen deleted the patch-1 branch April 23, 2020 16:07
@oleg-nenashev oleg-nenashev changed the title fix batch quoting in maybePublishIncrementals Fix batch quoting in maybePublishIncrementals Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@olblak olblak olblak approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jetersen @oleg-nenashev @jglick @olblak @timja