Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse JDK correctly in different formatted Jenkinsfile #224

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

sridamul
Copy link
Contributor

Now we can extract JDK values from Jenkinsfile that differs from the standard one.
Eg: https://github.com/jenkinsci/forensics-api-plugin/blob/main/Jenkinsfile

Testing done

Unit tests written

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@sridamul sridamul requested a review from a team as a code owner August 25, 2024 07:27
@jonesbusy jonesbusy merged commit 452ff0b into jenkins-infra:main Aug 25, 2024
14 checks passed
@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Aug 25, 2024
@sridamul sridamul deleted the parse-jenkinsfile branch August 25, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants