Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting fips test bundle #4082

Closed
olamy opened this issue Sep 10, 2024 · 8 comments
Closed

Hosting fips test bundle #4082

olamy opened this issue Sep 10, 2024 · 8 comments
Labels
hosting-request Request to host a component in jenkinsci needs-fix security-audit-done The hosting request code passed the security audit with success

Comments

@olamy
Copy link
Contributor

olamy commented Sep 10, 2024

Repository URL

https://github.com/olamy/fips-bundle-test

New Repository Name

lib-fips-bundle-test

Description

Provide test support tools for JEP-237
Related to PR jenkinsci/jenkins-test-harness#829

GitHub users to have commit permission

@olamy
@jtnord

Jenkins project users to have release permission

olamy
teilo

Issue tracker

GitHub issues

@olamy olamy added the hosting-request Request to host a component in jenkinsci label Sep 10, 2024
@jenkins-cert-app
Copy link
Collaborator

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

  • /audit-ok => the audit is complete, the hosting can continue 🎉.
  • /audit-skip => the audit is not necessary, the hosting can continue 🎉.
  • /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.29.12)

@jenkins-cert-app jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Sep 10, 2024
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: The parent pom version '1.122' should be at least '4.85' or higher.
  • ⛔ Required: The groupId for your parent pom is not "org.jenkins-ci.plugins," if this is not a plugin hosting request, you can disregard this notice.
  • ⛔ Required: The 'artifactId' from the pom.xml (fips-bundle-test) is incorrect, it should be lib-fips-bundle-test ('New Repository Name' field with "-plugin" removed)
  • ⛔ Required: The <groupId> from the pom.xml should be io.jenkins.plugins instead of io.jenkins.test.fips
  • ⛔ Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉


💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

@jenkins-cert-app jenkins-cert-app added security-audit-done The hosting request code passed the security audit with success and removed security-audit-todo The security team needs to audit the hosting request code labels Sep 10, 2024
@timja
Copy link
Member

timja commented Sep 11, 2024

/hosting host

@jenkins-infra-bot
Copy link
Contributor

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/lib-fips-bundle-test

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

Welcome aboard!

@olamy
Copy link
Contributor Author

olamy commented Sep 11, 2024

Thanks for the hosting.
Do I need to provide the yaml file for permissions?
As I got the error for first release

[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:3.1.3:deploy (default-deploy) on project fips-bundle-test: Failed to deploy artifacts: Could not transfer artifact io.jenkins.test.fips:fips-bundle-test:pom:0.0.1 from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): status code: 403, reason phrase:  (403) -> [Help 1]

@jtnord
Copy link
Contributor

jtnord commented Sep 11, 2024

Do I need to provide the yaml file for permissions?

yes #4082 (comment)

@olamy
Copy link
Contributor Author

olamy commented Sep 11, 2024

#4083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hosting-request Request to host a component in jenkinsci needs-fix security-audit-done The hosting request code passed the security audit with success
Projects
None yet
Development

No branches or pull requests

5 participants