Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission file for fips-bundle-test #4083

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

olamy
Copy link
Contributor

@olamy olamy commented Sep 11, 2024

Signed-off-by: Olivier Lamy olamy@apache.org

Link to GitHub repository

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

CD checklist (for submitters)

Reviewer checklist

There are IRC Bot commands for it.

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy requested a review from a team as a code owner September 11, 2024 09:59
@olamy olamy mentioned this pull request Sep 11, 2024
Copy link
Contributor

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have CD from the start though :)

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
Copy link
Contributor Author

olamy commented Sep 11, 2024

would be nice to have CD from the start though :)

sure let's make some marketing for GHA...

657b3d7

@timja timja merged commit c30e1c5 into jenkins-infra:master Sep 11, 2024
3 checks passed
@olamy olamy deleted the fips-bundle-test branch September 11, 2024 21:05
@daniel-beck
Copy link
Contributor

CD hasn't been properly set up, there's now a -rcwhatever release. That's why there's a checklist item specifically for CD enablement 😉

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

@olamy
Copy link
Contributor Author

olamy commented Sep 12, 2024

hopefully should be fixed here jenkinsci/lib-fips-bundle-test#2

@olamy
Copy link
Contributor Author

olamy commented Sep 12, 2024

this is fixed but the first release will break dependabot :(

https://repo.jenkins-ci.org/artifactory/releases/io/jenkins/test/fips/lib-fips-bundle-test/-rc16.e95456a_916d7/

I can see solutions:

@timja
Copy link
Member

timja commented Sep 13, 2024

Change the artifact id would be the smoothest I think

@olamy
Copy link
Contributor Author

olamy commented Sep 13, 2024

done here #4089

@olamy
Copy link
Contributor Author

olamy commented Sep 13, 2024

@timja thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants