Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert JENKINS-20679 #591

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Revert JENKINS-20679 #591

merged 1 commit into from
Aug 10, 2022

Conversation

basil
Copy link
Contributor

@basil basil commented May 7, 2022

Reverts #253. See the mailing list thread along with jenkinsci/jenkins#6549 and jenkinsci/maven-hpi-plugin#341. This is dead code, so we intend to stop producing it from maven-hpi-plugin and to stop consuming it from jenkins and update-center2. To test that dropping minimumJavaVersion from the Update Center won't affect older versions of Jenkins, I simulated this condition by setting this.minimumJavaVersion to null in jenkinsci/jenkins/core/src/main/java/hudson/model/UpdateSite.java. I refreshed the update center metadata successfully and updated several plugins without any issues.

@basil basil marked this pull request as ready for review May 7, 2022 21:20
@daniel-beck daniel-beck self-requested a review May 19, 2022 14:42
@daniel-beck daniel-beck added the enhancement This is an enhancement for the tool or wrapper scripts, typically adding features. label May 19, 2022
@daniel-beck daniel-beck merged commit aa691b2 into jenkins-infra:master Aug 10, 2022
@basil basil deleted the minimum branch August 10, 2022 20:11
@daniel-beck
Copy link
Contributor

FYI this is currently live through https://github.com/jenkins-infra/update-center2/tree/use-3.12.2; will make it permanent with a real release tomorrow unless there are complaints. (I don't expect there will be.)

@basil
Copy link
Contributor Author

basil commented Aug 10, 2022

Thank you Daniel! I don't expect any problems either given my testing, but I appreciate the heads up and will try to keep an eye on things just in case.

nfalco79 pushed a commit to nfalco79/update-center2 that referenced this pull request Aug 12, 2022
# Conflicts:
#	src/main/java/io/jenkins/update_center/Main.java
#	src/main/java/io/jenkins/update_center/PluginUpdateCenterEntry.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement for the tool or wrapper scripts, typically adding features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants