Revert JENKINS-20679 (support for plugin Java requirement metadata) #6549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3016. See the mailing list thread along with jenkinsci/maven-hpi-plugin#341 and jenkins-infra/update-center2#591. This is dead code, so we intend to stop producing it from
maven-hpi-plugin
(issuing a warning if users are still trying to specify this in their build configuration) and to stop consuming it fromjenkins
andupdate-center2
.Testing done
I did a corpus scan across all OSS and CloudBees plugins for plugins with
Minimum-Java-Version
in theirMETA-INF/MANIFEST.MF
. Almost all results were Java 8 or older.icq-notification
andsynopsys-sigma
were specifying a minimum version of Java 11, but we will be requiring that shortly so I do not see that as being an issue.outbound-webhook
was requiring Java 14 but this clearly seemed to be a bug as I was unable to find any reference to the string 14 in that repository's Git history.I additional did a corpus scan across all OSS and CloudBees plugins for usages of the field
hudson.model.UpdateSite.Plugin#minimumJavaVersion
and the methodshudson.model.UpdateSite.Plugin#getNeededDependenciesMinimumJavaVersion
,hudson.model.UpdateSite.Plugin#isForNewerJava
,hudson.model.UpdateSite.Plugin#isNeededDependenciesForNewerJava
,hudson.PluginWrapper#getMinimumJavaVersion
, andjenkins.plugins.DetachedPluginsUtil.DetachedPlugin#getMinimumJavaVersion
with no results.To test that dropping
minimumJavaVersion
from the Update Center won't affect older versions of Jenkins, I simulated this condition by settingthis.minimumJavaVersion
tonull
injenkinsci/jenkins/core/src/main/java/hudson/model/UpdateSite.java
. I refreshed the update center metadata successfully and updated several plugins without any issues.Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgrade@Restricted
or have@since TODO
Javadoc, as appropriate.Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are accurate, human-readable, and in the imperative moodupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).