Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert JENKINS-20679 (support for plugin Java requirement metadata) #6549

Merged
merged 4 commits into from
May 11, 2022

Conversation

basil
Copy link
Member

@basil basil commented May 7, 2022

Reverts #3016. See the mailing list thread along with jenkinsci/maven-hpi-plugin#341 and jenkins-infra/update-center2#591. This is dead code, so we intend to stop producing it from maven-hpi-plugin (issuing a warning if users are still trying to specify this in their build configuration) and to stop consuming it from jenkins and update-center2.

Testing done

I did a corpus scan across all OSS and CloudBees plugins for plugins with Minimum-Java-Version in their META-INF/MANIFEST.MF. Almost all results were Java 8 or older. icq-notification and synopsys-sigma were specifying a minimum version of Java 11, but we will be requiring that shortly so I do not see that as being an issue. outbound-webhook was requiring Java 14 but this clearly seemed to be a bug as I was unable to find any reference to the string 14 in that repository's Git history.

I additional did a corpus scan across all OSS and CloudBees plugins for usages of the field hudson.model.UpdateSite.Plugin#minimumJavaVersion and the methods hudson.model.UpdateSite.Plugin#getNeededDependenciesMinimumJavaVersion, hudson.model.UpdateSite.Plugin#isForNewerJava, hudson.model.UpdateSite.Plugin#isNeededDependenciesForNewerJava, hudson.PluginWrapper#getMinimumJavaVersion, and jenkins.plugins.DetachedPluginsUtil.DetachedPlugin#getMinimumJavaVersion with no results.

To test that dropping minimumJavaVersion from the Update Center won't affect older versions of Jenkins, I simulated this condition by setting this.minimumJavaVersion to null in jenkinsci/jenkins/core/src/main/java/hudson/model/UpdateSite.java. I refreshed the update center metadata successfully and updated several plugins without any issues.

Proposed changelog entries

  • Remove the ability for plugins to specify a minimum Java version. The minimum Java version of a plugin is always the same as the minimum Java version of the plugin's minimum core version.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added the work-in-progress The PR is under active development, not ready to the final review label May 7, 2022
@basil basil added removed This PR removes a feature or a public API and removed work-in-progress The PR is under active development, not ready to the final review labels May 7, 2022
@basil basil marked this pull request as ready for review May 7, 2022 22:13
@jglick jglick changed the title Revert JENKINS-20679 Revert JENKINS-20679 (support for plugin Java requirement metadata) May 10, 2022
@basil
Copy link
Member Author

basil commented May 10, 2022

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 10, 2022
@basil basil merged commit aa0513e into jenkinsci:master May 11, 2022
@basil basil deleted the minimum branch May 11, 2022 15:59
@MarkEWaite MarkEWaite added the developer Changes which impact plugin developers label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback removed This PR removes a feature or a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants