Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new version of jenkins-maven-cd-action #57

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Use new version of jenkins-maven-cd-action #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workflow-templates/cd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
distribution: 'adopt'
java-version: 8
- name: Release
uses: jenkins-infra/jenkins-maven-cd-action@v1.1.0
uses: jenkins-infra/jenkins-maven-cd-action@v1.2.0
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }}
Copy link

@h1dden-da3m0n h1dden-da3m0n Sep 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the change in jenkins-infra/jenkins-maven-cd-action#9 is the uName still needed here?
edit: sorry for the drive-by comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently yes, https://github.com/jenkins-infra/jenkins-maven-cd-action/blob/master/action.yaml#L6

technically no but needs a change and a release first

Copy link
Member

@jglick jglick Sep 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass it for now even though it is not currently being used, in case we decide to go back to basic auth.

Expand Down