Use new version of jenkins-maven-cd-action #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Sep 10, 2021
| @@ -52,7 +52,7 @@ jobs: | |||
| distribution: 'adopt' | |||
| java-version: 8 | |||
| - name: Release | |||
| uses: jenkins-infra/jenkins-maven-cd-action@v1.1.0 | |||
| uses: jenkins-infra/jenkins-maven-cd-action@v1.2.0 | |||
| with: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }} | |||
There was a problem hiding this comment.
based on the change in jenkins-infra/jenkins-maven-cd-action#9 is the uName still needed here?
edit: sorry for the drive-by comment
There was a problem hiding this comment.
Currently yes, https://github.com/jenkins-infra/jenkins-maven-cd-action/blob/master/action.yaml#L6
technically no but needs a change and a release first
There was a problem hiding this comment.
Pass it for now even though it is not currently being used, in case we decide to go back to basic auth.
oleg-nenashev
approved these changes
Sep 11, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danielbeck @jglick @oleg-nenashev
jenkins-infra/jenkins-maven-cd-action#9