ACI should use the configurable DNS server #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How it looks like
|
timja
approved these changes
Apr 10, 2022
src/main/resources/com/microsoft/jenkins/containeragents/aci/dns/AciDnsConfig/config.jelly
Outdated
Show resolved
Hide resolved
Thank you. I will do a manual test during this week. |
- ignoring whitespaces in image name - ignore empty dns server name
|
I tested it manually in Azure. |
sparsick
changed the title
timja
reviewed
Apr 14, 2022
src/main/java/com/microsoft/jenkins/containeragents/aci/dns/AciDnsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/jenkins/containeragents/aci/dns/AciDnsServer.java
Outdated
Show resolved
Hide resolved
- using better names
timja
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust the UI so that the DNS configuration for the deployment template can be filled out
Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue