Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71737] rename cloudName to name #462

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

car-roll
Copy link
Contributor

@car-roll car-roll commented Sep 14, 2023

Warning

This is a breaking change for anyone configuring Azure VM Agents with the configuration as code plugin

cloudName has been renamed to name adapt your templates

- cloudName: "linux"
+ name: "linux" 

Preparing for jenkinsci/jenkins#8310 where cloud name changes will be done on a separate page

The use of the variable name cloudName in AmazonEC2Cloud forces jenkins core to have a special case of handling cloudName when it not a variable of Cloud.
https://github.com/jenkinsci/jenkins/blob/d41b0f5807923286ad33d4847af95e2c6c7c77ba/core/src/main/java/jenkins/agents/CloudSet.java#L229

upstream of #460

Testing done

manually created, renamed, and deleted an AzureVMAgentsCloud

Submitter checklist

Preview Give feedback

@car-roll car-roll force-pushed the rename-cloudname-to-name branch from ad1a209 to 696b4b1 Compare September 14, 2023 04:27
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, all seems fine

@timja timja added the breaking A PR that is a breaking change - used by Release Drafter label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A PR that is a breaking change - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants