[JENKINS-71737] rename cloudName to name

[car-roll]

Preparing for jenkinsci/jenkins#8310 where cloud name changes will be done on a separate page

The use of the variable name cloudName in AmazonEC2Cloud forces jenkins core to have a special case of handling cloudName when it not a variable of Cloud.
https://github.com/jenkinsci/jenkins/blob/d41b0f5807923286ad33d4847af95e2c6c7c77ba/core/src/main/java/jenkins/agents/CloudSet.java#L229

Testing done

manually created new AmazonEC2Cloud
test in config-as-code integration tests: jenkinsci/configuration-as-code-plugin#2372

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist Loading

[car-roll]

All tests pass locally, and manual testing works fine. I'm not sure why I'm seeing a specific issue here in the CasC integration tests: jenkinsci/configuration-as-code-plugin#2372

[car-roll]

Sorry @res0nance would you mind taking a look at another PR? Related to jenkinsci/jenkins#8310

This is upstream of #891

also, I don't know if I would consider this a breaking change or not. It basically breaks jelly pages and CasC

edit: see simliar PR here: jenkinsci/azure-vm-agents-plugin#462

[car-roll]

This would need a release as well to support jenkinsci/configuration-as-code-plugin#2372

[nick-ax]

I can confirm that this is a breaking change for CasC 😢