[JENKINS-71737] rename cloudName to name #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
car-roll
force-pushed
the
remove-cloudname
branch
2 times, most recently
from
22eb276 to
71331b7
Compare
car-roll
force-pushed
the
remove-cloudname
branch
from
71331b7 to
601e0a3
Compare
6 tasks
|
All tests pass locally, and manual testing works fine. I'm not sure why I'm seeing a specific issue here in the CasC integration tests: jenkinsci/configuration-as-code-plugin#2372 |
|
Sorry @res0nance would you mind taking a look at another PR? Related to jenkinsci/jenkins#8310 This is upstream of #891 also, I don't know if I would consider this a breaking change or not. It basically breaks jelly pages and CasC edit: see simliar PR here: jenkinsci/azure-vm-agents-plugin#462 |
|
This would need a release as well to support jenkinsci/configuration-as-code-plugin#2372 |
res0nance
approved these changes
Sep 15, 2023
|
I can confirm that this is a breaking change for CasC 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for jenkinsci/jenkins#8310 where cloud name changes will be done on a separate page
The use of the variable name cloudName in AmazonEC2Cloud forces jenkins core to have a special case of handling cloudName when it not a variable of Cloud.
https://github.com/jenkinsci/jenkins/blob/d41b0f5807923286ad33d4847af95e2c6c7c77ba/core/src/main/java/jenkins/agents/CloudSet.java#L229
Testing done
manually created new AmazonEC2Cloud
test in config-as-code integration tests: jenkinsci/configuration-as-code-plugin#2372
Submitter checklist