-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Plugin Compatibility Tester from 0.2.1 to 0.3.0 #118
Conversation
prep.sh
Outdated
@@ -40,7 +40,7 @@ do | |||
done | |||
|
|||
# TODO find a way to encode this in some POM so that it can be managed by Dependabot | |||
version=0.2.1 | |||
version=0.3.0 | |||
timestamp=20190926.172941-2 # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/198 | |||
pct=$HOME/.m2/repository/org/jenkins-ci/tests/plugins-compat-tester-cli/${version}-SNAPSHOT/plugins-compat-tester-cli-${version}-${timestamp}.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to revert the timestamp
stuff added in 453f3d3 to pick up jenkinsci/plugin-compat-tester#198 which I waited for this release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removed it. Of a more robust implementation, there might be a follow-up
Co-Authored-By: Jesse Glick <jglick@cloudbees.com>
You could just set up Incrementals. It is already using the parent POM and ought to be in RPU, so should be easy enough using |
Sorry, I should not edit PRs from phone
…On Fri, Oct 4, 2019, 23:51 Basil Crow ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#118?email_source=notifications&email_token=AAW4RIBO3LFUOSUVGQP7HZ3QM63F5A5CNFSM4I5RVWT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG7Q43I#pullrequestreview-297733741>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW4RIDOQTJJXZ47AQOW7QDQM63F5ANCNFSM4I5RVWTQ>
.
|
Unfortunately, I do not think PCT 0.3.0 was released correctly. I have empirically observed that it does not contain my fix for jenkinsci/plugin-compat-tester#199 as mentioned in the release notes. From
Looks like PCT was erroneously released from a local branch corresponding to unmerged PR jenkinsci/plugin-compat-tester#194 rather than |
@oleg-nenashev Gentle ping. Would you be willing to re-release PCT from the correct branch? |
https://github.com/jenkinsci/plugin-compat-tester/releases/tag/plugins-compat-tester-aggregator-0.3.0