[JENKINS-58113] - Remove the Internal Maven Mode from PCT + Use maven from PATH when "-mvn" is not specified #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from PATH when "-mvn" is not specified
oleg-nenashev
commented
Sep 20, 2019
| <dependency> | ||
| <groupId>org.codehaus.plexus</groupId> | ||
| <artifactId>plexus-utils</artifactId> | ||
| <version>3.2.0</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.codehaus.plexus</groupId> | ||
| <artifactId>plexus-container-default</artifactId> |
There was a problem hiding this comment.
We can use it since we do not longer bundle Maven libs.
http://olamy.blogspot.com/2010/09/use-maven-3-apis-in-hudson-plugin.html from @olamy
jglick
approved these changes
Sep 20, 2019
| @@ -82,84 +81,6 @@ | |||
| </exclusion> | |||
| </exclusions> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.lib</groupId> | |||
| <artifactId>lib-jenkins-maven-embedder</artifactId> | |||
|
|
https://issues.jenkins-ci.org/browse/JENKINS-59470 for not using the Azure mirror in integration tests. It makes the run quite unstable |
jglick
approved these changes
Sep 23, 2019
plugins-compat-tester/pom.xml
Outdated
| @@ -36,8 +36,7 @@ | |||
| <artifactId>jenkins-core</artifactId> | |||
| </dependency> | |||
|
|
|||
| <!-- Upper bounds between core and Maven Embedder --> | |||
| <!-- TODO: All of that stuff happens due to Maven detaching. Would it be sane to include Maven Plugin 3.0 as a JAR instead? --> | |||
| <!--TODO: cleanup after removing GAE and the Jenkins core update --> | |||
|
Yes, need to merge branches
…On Mon, Sep 23, 2019, 20:01 Jesse Glick ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In plugins-compat-tester/pom.xml
<#194 (comment)>
:
> @@ -36,8 +36,7 @@
<artifactId>jenkins-core</artifactId>
</dependency>
- <!-- Upper bounds between core and Maven Embedder -->
- <!-- TODO: All of that stuff happens due to Maven detaching. Would it be sane to include Maven Plugin 3.0 as a JAR instead? -->
+ <!--TODO: cleanup after removing GAE and the Jenkins core update -->
GAE removal is merged, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#194?email_source=notifications&email_token=AAW4RIEILXU72KTX3RTYPODQLEABJA5CNFSM4IY3OJD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFTOE3Q#pullrequestreview-291955310>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW4RIGLEY7TVSYK7SSP473QLEABJANCNFSM4IY3OJDQ>
.
|
raul-arabaolaza
approved these changes
Oct 1, 2019
…move-maven-internal
…com/oleg-nenashev/plugin-compat-tester into JENKINS-58113-remove-maven-internal
# Conflicts: # plugins-compat-tester/src/main/java/org/jenkins/tools/test/hook/MultiParentCompileHook.java
|
Retriggering CI |
|
Everything is green except the JCasC test which will fail anyway. #214 was created to work it around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal Maven mode almost never works, and we do not really use it. I suggest we just remove this mode from PCT entirely.
https://issues.jenkins-ci.org/browse/JENKINS-58113