Bump configuration-as-code-plugin.version from 1.36 to 1.41 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
Bumps `configuration-as-code-plugin.version` from 1.36 to 1.39. Updates `configuration-as-code` from 1.36 to 1.39 - [Release notes](https://github.com/jenkinsci/configuration-as-code-plugin/releases) - [Commits](jenkinsci/configuration-as-code-plugin@configuration-as-code-1.36...configuration-as-code-1.39) Updates `test-harness` from 1.36 to 1.39 - [Release notes](https://github.com/jenkinsci/configuration-as-code-plugin/releases) - [Commits](jenkinsci/configuration-as-code-plugin@configuration-as-code-1.36...configuration-as-code-1.39) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
dependabot-preview
bot
added
the
dependencies
timja
requested changes
Apr 16, 2020
jetersen
reviewed
Apr 17, 2020
Comment on lines
+20
to
+29
| <dependency> | ||
| <groupId>io.jenkins</groupId> | ||
| <artifactId>configuration-as-code</artifactId> | ||
| <version>1.36</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.jenkins.configuration-as-code</groupId> | ||
| <artifactId>test-harness</artifactId> | ||
| <version>1.36</version> | ||
| </dependency> |
There was a problem hiding this comment.
Could this not be replaced by?
<configuration-as-code-plugin.version>1.36</configuration-as-code-plugin.version>There was a problem hiding this comment.
I’m not sure, don’t really know how properties work in inherited Poms like this
There was a problem hiding this comment.
It’s not something that should ever change as this is the last version that supports that line
|
fails: in script security Passes if I run it locally though =/ |
is wrong it should be:
|
|
Can reproduce with: |
|
@oleg-nenashev @amuniz @escoem Any idea ^^ |
|
Also passes if I change script-security to use the bom snapshot build from this branch =/ |
|
The only way I can think of that exception happening is by having two versions of The PCT does weird things with classpath and plugin versions, I'm not an expert in PCT (and I don't like it neither just because of things like this).
|
|
I've been trying to debug it by reproducing the PCT run in a way that I can inspect the classpath: But I got a totally different outcome which seems quite unrelated, so... I don't know. |
|
It fails in the same way when I run: boot classpath: |
|
Hmm, I think I might have found the issue. |
|
Yup |
|
So it's the PCT not correctly updating the pom. |
|
Correct, if I update the property the test passes, fun... |
|
Weird that it's only script-security it fails on |
|
@raul-arabaolaza do you have any recommendations on how to fix this? PCT is updating the configuration-as-code plugin but not it's test harness dependency which has an incompatible change in it, https://github.com/jenkinsci/script-security-plugin/blob/master/pom.xml#L79-L90 |
|
The PCT updates versions given a "context" of other plugins and versions, so when is running script security it sees Some hook could be created to set the |
|
I think the PCT should be able to detect that the version is being set through a property and update the property instead. |
|
That is what |
Ok, that is a good idea, I will work on that direction |
Once we add it to the Plugin POM, sure. I think it is reasonable for |
|
I think this is bad tests in
|
3 tasks
jglick
reviewed
Jun 4, 2020
prep.sh
Outdated
| @@ -42,7 +42,7 @@ done | |||
|
|
|||
| # TODO find a way to encode this in some POM so that it can be managed by Dependabot | |||
| version=0.5.1 | |||
| timestamp=20200409.141743-1 # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/228 | |||
| timestamp=20200512.100129-2 # TODO pending release > 0.5.1 | |||
There was a problem hiding this comment.
Suggested change
| timestamp=20200512.100129-2 # TODO pending release > 0.5.1 | |
| timestamp=20200512.100129-2 # TODO https://github.com/jenkinsci/plugin-compat-tester/pull/239 |
assuming this is from indeed from jenkinsci/plugin-compat-tester#239
|
🙏 that #247 passes and gets merged |
|
Should properly bump to 1.41 on jcasc |
timja
changed the title
timja
reviewed
Jun 5, 2020
timja
approved these changes
Jun 5, 2020
jetersen
approved these changes
Jun 5, 2020
|
@dependabot merge |
Very optimistic, I know 🤣 |
we did get a green build before you bumped the jcasc version 😂 |
|
Can't tell why it failed, build log is massive and is hanging in my browser, tests didn't fail |
|
Seems like try again. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot-preview
bot
deleted the
dependabot/maven/configuration-as-code-plugin.version-1.39
branch
jetersen
restored the
dependabot/maven/configuration-as-code-plugin.version-1.39
branch
|
|
dependabot-preview
bot
deleted the
dependabot/maven/configuration-as-code-plugin.version-1.39
branch
|
🎉 this one was hard :) |
|
Was good to finally land. Hopefully JCasC will have fewer breaking changes 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
configuration-as-code-plugin.versionfrom 1.36 to 1.39.Updates
configuration-as-codefrom 1.36 to 1.39Release notes
Sourced from configuration-as-code's releases.
Commits
f524a0e[maven-release-plugin] prepare release configuration-as-code-1.39064d2f2Fix compatibility with core 2.231 (#1359)f8dedcbset category name to Configuration for Jenkins v2.226+ (#1358)37b0684remove wip hint (#1352)4356946Improve SecretSource Javadoc (#1302)6682b0bAdd Gitter Q&A tab to the New Issue dialog (#1344)cb0e12e[maven-release-plugin] prepare for next development iteration59c5ff7[maven-release-plugin] prepare release configuration-as-code-1.38751431aFix classloading in snakeyaml (#1340)6314d5b[maven-release-plugin] prepare for next development iterationUpdates
test-harnessfrom 1.36 to 1.39Release notes
Sourced from test-harness's releases.
Commits
f524a0e[maven-release-plugin] prepare release configuration-as-code-1.39064d2f2Fix compatibility with core 2.231 (#1359)f8dedcbset category name to Configuration for Jenkins v2.226+ (#1358)37b0684remove wip hint (#1352)4356946Improve SecretSource Javadoc (#1302)6682b0bAdd Gitter Q&A tab to the New Issue dialog (#1344)cb0e12e[maven-release-plugin] prepare for next development iteration59c5ff7[maven-release-plugin] prepare release configuration-as-code-1.38751431aFix classloading in snakeyaml (#1340)6314d5b[maven-release-plugin] prepare for next development iterationDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @jetersen.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.ymlfile in this repo: