This tests are failing when running on the PCT #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `FolderTest.shouldHaveHealthMetricConfiguredGloballyOnCreation`: is checking [something](https://github.com/jenkinsci/cloudbees-folder-plugin/blob/2b9443b5c5d72030a92f59e8843c8948022830b5/src/test/java/com/cloudbees/hudson/plugins/folder/FolderTest.java#L420) which is not necessarily true (it depends on [this condition](https://github.com/jenkinsci/cloudbees-folder-plugin/blob/ae00f49fc0c6183983d67c799772fd8b9adc0840/src/main/java/com/cloudbees/hudson/plugins/folder/config/AbstractFolderConfiguration.java#L50)). So I suspect there is a `FolderHealthMetricDescriptor` in the classpath (from some other plugin) which is returning `null` on `FolderHealthMetricDescriptor#createDefault` (which is fine). 2. `AbstractFolderConfigurationTest#shouldBeAbleToRemoveHealthMetricConfiguredGlobally`: same reason.
|
The actual failure is happening on PCT runs (jenkinsci/bom#225 for example) |
amuniz
changed the title
jetersen
approved these changes
Jun 4, 2020
fcojfernandez
approved these changes
Jun 4, 2020
|
@fcojfernandez would you be able to release these changes? or should we ignore the tests in bom for now? |
|
I plan to do it tomorrow or next Monday morning (CET) at the latest. |
|
Thanks 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FolderTest.shouldHaveHealthMetricConfiguredGloballyOnCreation: is checking something which is not necessarily true (it depends on this condition). So I suspect there is aFolderHealthMetricDescriptorin the classpath (from some other plugin) which is returningnullonFolderHealthMetricDescriptor#createDefault(which is fine).AbstractFolderConfigurationTest#shouldBeAbleToRemoveHealthMetricConfiguredGlobally: same reason.Proposed changelog entries
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)@fcojfernandez