Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init 2.414.1 #2287

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Init 2.414.1 #2287

merged 2 commits into from
Jul 26, 2023

Conversation

NotMyFault
Copy link
Member

No description provided.

@NotMyFault NotMyFault added enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error. labels Jul 26, 2023
@NotMyFault NotMyFault requested a review from a team as a code owner July 26, 2023 16:02
@NotMyFault NotMyFault mentioned this pull request Jul 26, 2023
39 tasks
@MarkEWaite MarkEWaite enabled auto-merge (squash) July 26, 2023 16:11
@jglick
Copy link
Member

jglick commented Jul 26, 2023

@MarkEWaite please just double-check that the full-test label, applied after filing the PR, is honored. I think it should be because

if (BRANCH_NAME == 'master' || fullTestMarkerFile || env.CHANGE_ID && pullRequest.labels.contains('full-test')) {
is checked after the prep phase and I believe the label lookup uses the current state of the PR rather than the state at the time the build started.

@MarkEWaite
Copy link
Contributor

@MarkEWaite please just double-check that the full-test label, applied after filing the PR, is honored.

Will do. I won't merge this until we have a confirmed pass of full-test with actual execution of the tests.

@jglick
Copy link
Member

jglick commented Jul 26, 2023

I just checked and it is running PCT, so automerge should be fine.

@MarkEWaite MarkEWaite merged commit 9b49973 into jenkinsci:master Jul 26, 2023
498 checks passed
@NotMyFault NotMyFault deleted the init-2.414 branch July 26, 2023 19:25
@jglick
Copy link
Member

jglick commented Jul 28, 2023

Do you plan to release this? jenkinsci/ec2-plugin#875 would apparently use it (@car-roll).

@MarkEWaite
Copy link
Contributor

Happy to release it today or tomorrow.

<profile>
<id>2.401.x</id>
<properties>
<bom>2.401.x</bom>
<jenkins.version>2.401.1</jenkins.version>
<jenkins.version>2.401.3</jenkins.version>
Copy link
Member

@jglick jglick Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think according to the above logic this should have remained 2.401.1 until 2.414.1 was released. As of #2408 it no longer matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants