Test support for cloud management changes

[car-roll]

The moving of cloud management to multiple pages (jenkinsci/jenkins#7658) appear to have broken some tests.

Bug also discovered when changing cloud name. See https://issues.jenkins.io/browse/JENKINS-71737

Also upstream of #888

cc @Vlatombe

Testing done

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist Loading

[car-roll]

So testSshKeysCredentialsIdRemainsUnchangedAfterUpdatingOtherFields still fails. Looks to be a regression. When you change the cloud node name, the user then receives a 404 saying the URL to the old cloud config page does not exist.
However, the cloud name does change successfully when you go back, it's just that submitting the name change tries to take you back to the old cloud name config page.

Will look into James' comment about Items requiring special handling for renames.

[car-roll]

It does look like 'Clouds' handles the name change successfully
https://github.com/jenkinsci/jenkins/blob/e1d64393f6001821d7a0448205bc6544421ead32/core/src/main/java/hudson/slaves/Cloud.java#L317

I guess the return url after the save is not being done correctly...somewhere...

Update: interesting, did some debugging and the test passed. Might be a race condition somewhere?

[car-roll]

Turns out the issue is here: https://github.com/jenkinsci/jenkins/blob/31721319231f19bead0adcbb005b99c84a6f9171/core/src/main/java/hudson/slaves/Cloud.java#L334
The redirect is incorrect to return to the top of the clouds page. Will file a PR for fix.

[raul-arabaolaza]

I beieve this handles properly the UI changes, while the 404 is managed by the core pr, I see no reason not to ship this fixes.

[raul-arabaolaza]

I believe we should try to move this forward

[car-roll]

@Vlatombe I believe this PR is ready for review now. Would you be able to take a look at it?

[car-roll]

Sorry forgot to remove an unnecessary TODO (related to name change fixes). I changed the test so it didn't rely on name changes and just changed a different property.

[car-roll]

dealing with CI flakes

[car-roll]

@res0nance Could you take a look at this PR? Tests fail here when the jenkins version is upgraded. It also revealed a regression in core (See jenkinsci/jenkins#8310)

Will continue to work on getting CI to pass. I believe it is infrastructure right now that is making it fail.

[car-roll]

ci now passes

[res0nance]

Hi @car-roll changes look fine would you like this merged or do you still have work to do in this area?

[car-roll]

Hi @res0nance this PR is done so we can merge it 🚀 many thanks!