Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @res0nance
Preparing for jenkinsci/jenkins#8310 where cloud name changes will be done on a separate page
The use of the variable name
cloudName
inAmazonEC2Cloud
forces jenkins core to have a special case of handlingcloudName
when it not a variable ofCloud
.https://github.com/jenkinsci/jenkins/blob/d41b0f5807923286ad33d4847af95e2c6c7c77ba/core/src/main/java/jenkins/agents/CloudSet.java#L229
Also changed
AmazonEC2CloudTest.testSshKeysCredentialsIdRemainsUnchangedAfterUpdatingOtherFields
to modify a different field.Testing done
manually created new
AmazonEC2Cloud
Submitter checklist