Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename cloudName to name #888

Closed
wants to merge 3 commits into from
Closed

Conversation

car-roll
Copy link
Contributor

@car-roll car-roll commented Sep 11, 2023

cc @res0nance
Preparing for jenkinsci/jenkins#8310 where cloud name changes will be done on a separate page

The use of the variable name cloudName in AmazonEC2Cloud forces jenkins core to have a special case of handling cloudName when it not a variable of Cloud.
https://github.com/jenkinsci/jenkins/blob/d41b0f5807923286ad33d4847af95e2c6c7c77ba/core/src/main/java/jenkins/agents/CloudSet.java#L229

Also changed AmazonEC2CloudTest.testSshKeysCredentialsIdRemainsUnchangedAfterUpdatingOtherFields to modify a different field.

Testing done

manually created new AmazonEC2Cloud

Submitter checklist

@car-roll car-roll marked this pull request as draft September 11, 2023 19:01
@car-roll car-roll marked this pull request as ready for review September 11, 2023 19:05
@@ -4,7 +4,7 @@ configuration-as-code:
jenkins:
clouds:
- amazonEC2:
cloudName: "test"
name: "test"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar issue also exists in the integration tests for configuration-as-code-plugin

@car-roll car-roll closed this Sep 11, 2023
@car-roll car-roll reopened this Sep 11, 2023
@car-roll
Copy link
Contributor Author

CI issues

@car-roll
Copy link
Contributor Author

Closing in favor of a less invasive change

@car-roll car-roll closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants