Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nodejs to the managed set #3490

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add nodejs to the managed set #3490

merged 1 commit into from
Aug 26, 2024

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Aug 26, 2024 •
edited
Loading

Add nodejs to the managed set

Fixes #2437

Special thanks to @nfalco79 for the release of

Testing done

Confirmed that mvn clean verify and PLUGINS=nodejs bash local-test.sh both pass.

Also using this test to check that git plugin 5.4.1 passes full tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Include nodejs plugin in the bill of materials
4388c12 
Fixes jenkinsci#2437

Special thanks to @nfalco79 for the release of
jenkinsci/nodejs-plugin#122

The nodejs 1.6.2 plugin is the release.
@MarkEWaite MarkEWaite added the full-test Test all LTS lines in this PR and do not halt upon first error. label Aug 26, 2024
@MarkEWaite MarkEWaite requested a review from a team as a code owner August 26, 2024 16:33
@MarkEWaite MarkEWaite added the enhancement New feature or request label Aug 26, 2024
@MarkEWaite MarkEWaite changed the title Include nodejs plugin in the bill of materials Include nodejs plugin in bill of materials Aug 26, 2024
@MarkEWaite MarkEWaite changed the title Include nodejs plugin in bill of materials Add nodejs to the managed set Aug 26, 2024
basil
basil approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit f893361 into jenkinsci:master Aug 26, 2024
733 checks passed
@MarkEWaite MarkEWaite deleted the add-nodejs-plugin branch August 26, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NodeJS to the managed set
2 participants
@MarkEWaite @basil