Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloudbees-folder to test scope #122

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Add cloudbees-folder to test scope #122

merged 1 commit into from
Sep 8, 2023

Conversation

basil
Copy link
Member

@basil basil commented Sep 6, 2023

While running Plugin Compatibility Tester (PCT) against this plugin I noticed the following failure:

java.lang.ClassNotFoundException: com.cloudbees.hudson.plugins.folder.AbstractFolder
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
Caused: java.lang.NoClassDefFoundError: com/cloudbees/hudson/plugins/folder/AbstractFolder
	at org.jenkinsci.plugins.configfiles.ConfigFiles.getByIdOrNull(ConfigFiles.java:139)
	at org.jenkinsci.plugins.configfiles.ConfigFiles.getByIdOrNull(ConfigFiles.java:169)
	at org.jenkinsci.lib.configprovider.model.ConfigFileManager.provisionConfigFile(ConfigFileManager.java:67)
	at jenkins.plugins.nodejs.NodeJSCommandInterpreter.perform(NodeJSCommandInterpreter.java:172)
	at hudson.tasks.CommandInterpreter.perform(CommandInterpreter.java:92)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:818)
	at hudson.model.Build$BuildExecution.build(Build.java:199)
	at hudson.model.Build$BuildExecution.doRun(Build.java:164)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:526)
	at hudson.model.Run.execute(Run.java:1895)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:44)
	at hudson.model.ResourceController.execute(ResourceController.java:101)
	at hudson.model.Executor.run(Executor.java:442)

This PR chases away the failure by adding cloudbees-folder (of a BOM managed version) to test scope.

Testing done

Successfully ran PCT with this change on Java 21. Before this change, I got:

[ERROR] Errors: 
[ERROR]   JCasCTest>RoundTripAbstractTest.lambda$roundTripTest$0:104->assertConfiguredAsExpected:64->checkConfigFile:69 » NoClassDefFound com/cloudbees/hudson/plugins/folder/AbstractFolder
[ERROR]   NpmrcFileSupplyTest.test_supply_npmrc_with_registry:67 » NoClassDefFound com/cloudbees/hudson/plugins/folder/AbstractFolder

@basil basil added the test label Sep 6, 2023
@basil basil requested a review from a team as a code owner September 6, 2023 21:03
@basil basil mentioned this pull request Sep 6, 2023
Closed
@basil
Copy link
Member Author

basil commented Sep 7, 2023

Currently blocking jenkinsci/bom#2437

MarkEWaite
MarkEWaite approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nfalco79 nfalco79 merged commit f02f523 into jenkinsci:master Sep 8, 2023
@MarkEWaite
Copy link
Contributor

Thanks for merging @nfalco79 ! Looking forward to a release so that this plugin can be included in the bill of materials.

@basil basil deleted the pct branch September 12, 2023 21:30
@basil
Copy link
Member Author

basil commented Apr 30, 2024

Looking forward to a release so that this plugin can be included in the bill of materials.

I am looking forward to it, too!

MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Aug 26, 2024
@MarkEWaite
Include nodejs plugin in the bill of materials
4388c12 
Fixes jenkinsci#2437

Special thanks to @nfalco79 for the release of
jenkinsci/nodejs-plugin#122

The nodejs 1.6.2 plugin is the release.
@MarkEWaite MarkEWaite mentioned this pull request Aug 26, 2024
Merged
6 tasks
basil pushed a commit to jenkinsci/bom that referenced this pull request Aug 26, 2024
@MarkEWaite
Include nodejs plugin in the bill of materials (#3490)
f893361 
Fixes #2437

Special thanks to @nfalco79 for the release of
jenkinsci/nodejs-plugin#122

The nodejs 1.6.2 plugin is the release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basil @MarkEWaite @nfalco79